cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard
verified publisher icon huggingface

Translation into Russian - first PR

Open artyomboyko opened this issue 1 year ago • 15 comments

This is the first PR translation of the cookbook into Russian.

Any native speaker from the HF team can do the review. An earlier review was done by @MKhalusova.

artyomboyko avatar May 10 '24 11:05 artyomboyko

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

review-notebook-app[bot] avatar May 10 '24 11:05 review-notebook-app[bot]

#92

artyomboyko avatar May 10 '24 11:05 artyomboyko

@merveenoyan @stevhliu Hello, have a good day)

A few questions:

  1. How do I get a review here?
  2. Earlier documentation was built on a "demo server" and you could see if everything was correct (like here). Is there any way to do that now (To make sure I don't break anything with my PR)?

artyomboyko avatar May 11 '24 15:05 artyomboyko

@stevhliu Hello Steven. Can you please tell me who can do a review?

artyomboyko avatar May 12 '24 11:05 artyomboyko

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

HuggingFaceDocBuilderDev avatar May 13 '24 18:05 HuggingFaceDocBuilderDev

Hi, thanks for the translation!

  1. You can ping Merve or I for a review, but please be patient :)
  2. The preview is automatically generated when we approve and run the workflow.
  3. I would check the forums or Discord to see if there is another contributor who can read Russian to review your translation.

stevhliu avatar May 13 '24 18:05 stevhliu

@stevhliu Greate Thanks. But i dont see Russian in docs PR preview:

image

And I dont undestand why?

artyomboyko avatar May 13 '24 18:05 artyomboyko

@stevhliu I think I found the problem:

image

I have not added the language code to the documentation build files (YAML files).

artyomboyko avatar May 13 '24 19:05 artyomboyko

@stevhliu How we can rebuild doc preview?

artyomboyko avatar May 15 '24 00:05 artyomboyko

@stevhliu @merveenoyan Hello. HuggingFaceDocBuilderDev still does not show RU in preview. I've made all the necessary edits, but it just doesn't seem to be rebuilding the documentation.

image

How do I initiate a rebuild of the preview? If of course I can do that.

artyomboyko avatar May 15 '24 18:05 artyomboyko

It should work now :)

stevhliu avatar May 16 '24 17:05 stevhliu

@stevhliu @merveenoyan Good day. Anyway, I haven't found anyone who could do a review for Russian. I made it myself - by myself. Can I run the documentation preview build again? I want to see how the edits I made will look like.

artyomboyko avatar May 18 '24 10:05 artyomboyko

@stevhliu @merveenoyan Good evening. Checked out the previews. Looks and reads good. We can merge.

artyomboyko avatar May 21 '24 16:05 artyomboyko

@stevhliu @merveenoyan

I can help with the review (my native language is Russian). For other languages I can help with formatting and other small things like that. But I have never done it before. But I think - I will learn, the main thing is to try).

artyomboyko avatar May 21 '24 16:05 artyomboyko

Thanks for your translation, we appreciate your effort and work! However, to ensure the Cookbook's quality, we really should have a review from someone else who can also read Russian just to ensure there are no typos and it translates well. Hope you understand! 🤗

stevhliu avatar May 22 '24 16:05 stevhliu