cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Adding Catala as new language in notebooks/translated `rag_zephyr_langchain`

Open JanLeyva opened this issue 1 year ago • 6 comments

What does this PR do?

This PR adds the folder ca to the notebooks directory. The purpose is to include translated notebooks in Catalan, as well as to translate the rag_zephyr_langchain notebook into this language. I have already translated Index.md inside the ca folder and made modifications to _toctree.yaml as well.

This marks my first contribution, and I welcome any feedback!

Who can review?

Someone that can check I did the structure properly, no technical changes made just translated a notebook and added a language. @adeenayakup @MKhalusova

JanLeyva avatar Apr 05 '24 18:04 JanLeyva

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@MKhalusova @davanstrien can you please take a look? or give me feedback, thanks!

JanLeyva avatar Apr 24 '24 10:04 JanLeyva

@JanLeyva Hello. In order to fully add language support, a couple more edits need to be made.

image

You can see how I did it for Russian.

image

artyomboyko avatar May 15 '24 18:05 artyomboyko

@blademoon added ca as a language in build_documentation.yml and build_pr_documentation.yml in .github/workflows. Thanks for pointing this out, completely missed this step.

JanLeyva avatar May 16 '24 09:05 JanLeyva

@stevhliu Good day. Can you approve doc preview building?

artyomboyko avatar May 16 '24 20:05 artyomboyko

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.