cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Translated rag_zephyr_langchain.ipynb to Korean

Open jun048098 opened this issue 1 year ago โ€ข 1 comments

What does this PR do?

This is PR presents the Korean translation of Simple RAG for GitHub issues using Hugging Face Zephyr and LangChain cookbook

Fixes # (issue)

Who can review?

@4N3MONE, @jeongiin @boyunJang, @ahnjj, @SeungAhSon, @jun048098, @win2dvp21

jun048098 avatar Oct 06 '24 17:10 jun048098

Check out this pull request onย  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

It's best to keep the filename rag_zephyr_langchain.ipynb under ko ๐Ÿ˜Š @jun048098 ๊ณ ๋ง™์Šต๋‹ˆ๋‹ค I checked using translation, LGTM if you think as well, after the conflicts are resolved we can merge

merveenoyan avatar Oct 21 '24 07:10 merveenoyan

It's best to keep the filename rag_zephyr_langchain.ipynb under ko ๐Ÿ˜Š @jun048098 ๊ณ ๋ง™์Šต๋‹ˆ๋‹ค I checked using translation, LGTM if you think as well, after the conflicts are resolved we can merge

The original text used Hugging Face Zephyr. In translation, eeve was used to use the Korean model. For this reason, I changed the ipynb file name.

However, I changed it back to the original rag_zephyr_langchain.ipynb. Also, the conflict was resolved.

@merveenoyan thank you!

jun048098 avatar Oct 21 '24 08:10 jun048098

@jun048098 it's nice you adapted it, I feel like it's best to keep the equivalent of the exact same one so people can switch between languages. If you can get one of the fellow Koreans to approve we can merge (also there are some merge conflicts due to recently merged Korean recipes)

merveenoyan avatar Oct 26 '24 20:10 merveenoyan

@merveenoyan @stevhliu Hello! I received an apporve from a Korean reviewer. Is merging possible? thank you

jun048098 avatar Oct 27 '24 11:10 jun048098

@jun048098 feel free to join this org: https://huggingface.co/huggingcooks

merveenoyan avatar Oct 27 '24 19:10 merveenoyan

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.