cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Translated `faiss_with_hf_datasets_and_clip.md` to Korean

Open jeongiin opened this issue 1 year ago โ€ข 1 comments

What does this PR do?

This is PR presents the korean translation of Embedding multimodal data for similarity search using ๐Ÿค— transformers, ๐Ÿค— datasets and FAISS cookbook.

Who can review?

@4N3MONE, @harheem, @boyunJang, @ahnjj, @SeungAhSon,@jun048098,@win2dvp21

jeongiin avatar Sep 27 '24 18:09 jeongiin

Check out this pull request onย  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jeongiin ๊ณ ๋ง™์Šต๋‹ˆ๋‹ค once reviewed by other Korean speakers we can merge :)

merveenoyan avatar Oct 21 '24 07:10 merveenoyan

LGTM! ๋ฒˆ์—ญ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

jun048098 avatar Oct 21 '24 08:10 jun048098

์ข€ ๋งŽ์ด ๋Šฆ์—ˆ์ง€๋งŒ...๊ทธ๋ฆฌ๊ณ  ๋งŽ์ด ๊ณ ์นœ ๋ถ€๋ถ„์€ ์—†์ง€๋งŒ ๋ฆฌ๋ทฐ ๋‚จ๊น๋‹ˆ๋‹ค! ์ฃผ์„ ํ•œ๊ตญ์–ด๋กœ ๋ฐ”๊พธ๋Š” ๋ถ€๋ถ„๋งŒ ํ™•์ธํ•ด๋ณด๋ฉด ๋  ๊ฒƒ ๊ฐ™์•„์š”! ์ฟก๋ถ ์ œ์ž‘ํ•˜๋А๋ผ ์ •๋ง ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

boyunJang avatar Oct 27 '24 07:10 boyunJang

nice to translate the comments! @boyunJang @jeongiin also thanks for picking this I wrote this recipe it makes me happy ๐Ÿ˜‚ we made an org for cookbook authors, sort of like a badge on your profile if you request to join after this is merged: https://huggingface.co/huggingcooks

merveenoyan avatar Oct 27 '24 18:10 merveenoyan

There's an issue with the CI atm regarding rendering of Korean characters, CI gets stuck. we're waiting on our colleague to fix this. we'll merge afterwards

merveenoyan avatar Oct 30 '24 21:10 merveenoyan

@merveenoyan I'm glad I could contribute too! Thank you for writing a great recipe :) It's really exciting to be able to receive a badge! I hope it merges! Have a nice day ๐Ÿ‘

jeongiin avatar Oct 31 '24 02:10 jeongiin

@jeongiin the issue with the CI was fixed, would you like to merge main into this branch, we can check if the CI passes and then merge this PR

merveenoyan avatar Dec 10 '24 15:12 merveenoyan

@merveenoyan Of course! I've been waiting for this! Please let me know if there's anything else I need to do.

jeongiin avatar Dec 10 '24 16:12 jeongiin

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@merveenoyan Happy new year! Could I get this reviewed?

jeongiin avatar Jan 02 '25 05:01 jeongiin