chat-ui icon indicating copy to clipboard operation
chat-ui copied to clipboard

[Assitants] Community | User tabs

Open mishig25 opened this issue 1 year ago • 1 comments

Have a tab/picker between "community" or "my" assistants

Scenario 1: I'm not logged in

Screenshot 2024-02-04 at 6 37 45 PM

Scenario 2: I'm logged in as "mishig" & I go to "?assistants" Screenshot 2024-02-04 at 6 37 56 PM

Scenario 3: I'm logged in as "mishig" & I go to "?assistants?user=victor" Screenshot 2024-02-04 at 6 37 26 PM

Scenario 4: I'm logged in as "mishig" & I go to "?assistants?user=mishig" Screenshot 2024-02-04 at 6 38 43 PM

mishig25 avatar Feb 04 '24 18:02 mishig25

Updated behaviour.

for the info, I'm logged in as user "mishig"

https://github.com/huggingface/chat-ui/assets/11827707/eafd8e64-8899-492b-92bb-e967d4ed5974

note: when I open "?user=victor". This is what I see. Once I click to "My assistants", "Victor's assissntas" are gone & turns into "Community"

https://github.com/huggingface/chat-ui/assets/11827707/143557ff-d37c-42ce-95e0-a9ab0c13b86e

mishig25 avatar Feb 05 '24 10:02 mishig25

if this pr is taking long time, maybe we can just cherry-pick & merge https://github.com/huggingface/chat-ui/pull/773/commits/9a21527a9ecaf9840e1e3f0922591166c1a2c8cd to main ?

mishig25 avatar Feb 07 '24 11:02 mishig25

What's the blocker for the PR? :eyes:

nsarrazin avatar Feb 07 '24 11:02 nsarrazin

What's the blocker for the PR? 👀

I've updated it a bit, it should be ready now.

gary149 avatar Feb 07 '24 16:02 gary149

Right now when you are on some user's or your assistant (i.e. the url has ?user=xyz) & choose a model from dropdown, it removes user from searchQuery. Should the user persist in searchQuery in this case or not?

mishig25 avatar Feb 07 '24 21:02 mishig25

Updates:

  1. Refactored getHref utility func https://github.com/huggingface/chat-ui/pull/773#discussion_r1482189358
  2. Regarding this comment, made this commit https://github.com/huggingface/chat-ui/pull/773/commits/b7ede7fc68b44b9fc2ed4237aaa8cd7e606238a2 which preserves the user as model id changes

mishig25 avatar Feb 07 '24 22:02 mishig25

Please let me know if there's anything else

mishig25 avatar Feb 07 '24 22:02 mishig25

Commit https://github.com/huggingface/chat-ui/pull/773/commits/c41f2356f0959d9a2e710b023ac02475d98d9ae0

Before; it was showing single "Community" btn for non-logged in users

Screenshot 2024-02-08 at 10 58 43 AM

After https://github.com/huggingface/chat-ui/pull/773/commits/c41f2356f0959d9a2e710b023ac02475d98d9ae0; non-logged in users won't see "Community" btn. Only logged-in users would see "Community" btn AND "their name" btn

Screenshot 2024-02-08 at 10 59 48 AM

mishig25 avatar Feb 08 '24 10:02 mishig25