chat-ui
chat-ui copied to clipboard
[Assitants] Community | User tabs
Have a tab/picker between "community" or "my" assistants
Scenario 1: I'm not logged in
Scenario 2: I'm logged in as "mishig" & I go to "?assistants"
Scenario 3: I'm logged in as "mishig" & I go to "?assistants?user=victor"
Scenario 4: I'm logged in as "mishig" & I go to "?assistants?user=mishig"
Updated behaviour.
for the info, I'm logged in as user "mishig"
https://github.com/huggingface/chat-ui/assets/11827707/eafd8e64-8899-492b-92bb-e967d4ed5974
note: when I open "?user=victor". This is what I see. Once I click to "My assistants", "Victor's assissntas" are gone & turns into "Community"
https://github.com/huggingface/chat-ui/assets/11827707/143557ff-d37c-42ce-95e0-a9ab0c13b86e
if this pr is taking long time, maybe we can just cherry-pick & merge https://github.com/huggingface/chat-ui/pull/773/commits/9a21527a9ecaf9840e1e3f0922591166c1a2c8cd to main ?
What's the blocker for the PR? :eyes:
What's the blocker for the PR? 👀
I've updated it a bit, it should be ready now.
Right now when you are on some user's or your assistant (i.e. the url has ?user=xyz
) & choose a model from dropdown, it removes user
from searchQuery. Should the user
persist in searchQuery in this case or not?
Updates:
- Refactored
getHref
utility func https://github.com/huggingface/chat-ui/pull/773#discussion_r1482189358 - Regarding this comment, made this commit https://github.com/huggingface/chat-ui/pull/773/commits/b7ede7fc68b44b9fc2ed4237aaa8cd7e606238a2 which preserves the
user
as model id changes
Please let me know if there's anything else
Commit https://github.com/huggingface/chat-ui/pull/773/commits/c41f2356f0959d9a2e710b023ac02475d98d9ae0
Before; it was showing single "Community" btn for non-logged in users
After https://github.com/huggingface/chat-ui/pull/773/commits/c41f2356f0959d9a2e710b023ac02475d98d9ae0; non-logged in users won't see "Community" btn. Only logged-in users would see "Community" btn AND "their name" btn