Navigation: load discussion
This looks super cool thanks!! Will review
Adding Infinite scroll
@KartikGS How you tested it?? Can you please tell
Adding Infinite scroll
@KartikGS How you tested it?? Can you please tell
Currently 300 conversations are being fetched. Reduce the limit and total to 15, set extra to 3 and make sure you have enough conversations
Tested this locally works great 🔥 Thanks for an awesome PR. Could you explain to me some small aspects of the code ? Mostly:
- Why did you need an extra store
convUpdate? - What is the issue you were fixing with the
extraConversationarray and passing"extra"as a param tofetchData? Something with consistency but I can't figure it out just looking at the code. 👀
Not saying any of this is wrong BTW, just trying to fully get it before merging 😁
convUpdate- After starting a new conversation consistency is maintained as fetchData is called, that is not the case when you continue or retry conversations in extraConversations. Using the new store to deal with this.
extraConversation and ”extra”- I don’t know what you are referring to, but here I don’t want pass limit = 0 and fetch all conversations.
Sorry if I misunderstood something 😅. Feel free to ask or correct me if I’m wrong.
shouldn't this have been merged already?