chat-ui icon indicating copy to clipboard operation
chat-ui copied to clipboard

Navigation: load discussion

Open KartikGS opened this issue 1 year ago • 6 comments

fixes #945

Adding Infinite scroll

Limit_15_for_demo.webm

KartikGS avatar Apr 18 '24 12:04 KartikGS

This looks super cool thanks!! Will review

nsarrazin avatar Apr 19 '24 07:04 nsarrazin

Adding Infinite scroll

@KartikGS How you tested it?? Can you please tell

KingNish24 avatar Apr 19 '24 12:04 KingNish24

Adding Infinite scroll

@KartikGS How you tested it?? Can you please tell

Currently 300 conversations are being fetched. Reduce the limit and total to 15, set extra to 3 and make sure you have enough conversations

KartikGS avatar Apr 19 '24 13:04 KartikGS

Tested this locally works great 🔥 Thanks for an awesome PR. Could you explain to me some small aspects of the code ? Mostly:

  • Why did you need an extra store convUpdate ?
  • What is the issue you were fixing with the extraConversation array and passing "extra" as a param to fetchData ? Something with consistency but I can't figure it out just looking at the code. 👀

Not saying any of this is wrong BTW, just trying to fully get it before merging 😁

nsarrazin avatar Apr 22 '24 07:04 nsarrazin

convUpdate- After starting a new conversation consistency is maintained as fetchData is called, that is not the case when you continue or retry conversations in extraConversations. Using the new store to deal with this.

extraConversation and ”extra”- I don’t know what you are referring to, but here I don’t want pass limit = 0 and fetch all conversations.

Sorry if I misunderstood something 😅. Feel free to ask or correct me if I’m wrong.

KartikGS avatar Apr 22 '24 10:04 KartikGS

shouldn't this have been merged already?

SvCy avatar May 21 '24 19:05 SvCy