accelerate icon indicating copy to clipboard operation
accelerate copied to clipboard

MLU devices : Checks if mlu is available via an cndev-based check which won't trigger the drivers and leave mlu

Open huismiling opened this issue 1 year ago • 3 comments

What does this PR do?

MLU devices : Checks if mlu is available via an cndev-based check which won't trigger the drivers and leave mlu

Check devices(cuda and mlu) is available with patch_environment .

Move clear_environment and patch_environment into src/accelerate/utils/environment.py to avoid circular import .

Before submitting

  • [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [x] Did you read the contributor guideline, Pull Request section?
  • [ ] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • [ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • [ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

huismiling avatar Oct 23 '24 02:10 huismiling

@BenjaminBossan @muellerzr Previous PR https://github.com/huggingface/accelerate/pull/3057 is closed. Sorry for taking so long time to fix circular import. clear_environment and patch_environment are moved into src/accelerate/utils/environment.py .

huismiling avatar Oct 23 '24 02:10 huismiling

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Yep exactly. We can add a deprecation warning here but we've never advertised it in that way at that import level so I think we should be fine.

muellerzr avatar Oct 23 '24 18:10 muellerzr

Okay, great, just wanted to be sure. This PR is good to be merged from my point of view.

BenjaminBossan avatar Oct 24 '24 12:10 BenjaminBossan