accelerate icon indicating copy to clipboard operation
accelerate copied to clipboard

missing online doc even though the docstring exists

Open stas00 opened this issue 1 year ago • 11 comments

https://huggingface.co/docs/accelerate/main/en/package_reference/accelerator?search=true doesn't seem to cover all the documented functions/methods.

e.g. searching for gather_object gives nada: snapshot_526

but the docstring is there: https://github.com/huggingface/accelerate/blob/d1abd59114ada8ba673e1214218cb2878c13b82d/src/accelerate/utils/operations.py#L417-L426

It does find gather on the other hand.

stas00 avatar Dec 27 '23 00:12 stas00

It seems that searching in accelerate docs does not work. Inputing "gather" does not return results, either.

george-kuanli-peng avatar Jan 04 '24 07:01 george-kuanli-peng

Thanks for reporting.

It does find gather on the other hand.

There is an entry for gather here that generates an API reference, but gather_object is missing, which is why it doesn't show up. Not sure if there is any logic to which function is included and which isn't, probably this is just an oversight?@muellerzr

It seems that searching in accelerate docs does not work.

This seems to be a separate issue right now, we're investigating.

BenjaminBossan avatar Jan 04 '24 13:01 BenjaminBossan

@BenjaminBossan yup there's some missing entries in the utils doc that need to be added. (We don't do everything for the utils, just what is in the __init__.py under utils/ but seems some are missing!)

muellerzr avatar Jan 04 '24 13:01 muellerzr

@george-kuanli-peng The search feature in docs should be working correctly again.

BenjaminBossan avatar Jan 05 '24 14:01 BenjaminBossan

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Jan 29 '24 15:01 github-actions[bot]

unstale, this is still unresolved.

stas00 avatar Jan 29 '24 17:01 stas00

Thanks Stas, yes indeed. A doc sprint is next on my list as we near 1.0.0 :)

muellerzr avatar Jan 29 '24 19:01 muellerzr

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Feb 23 '24 15:02 github-actions[bot]

unstale, this is still unresolved.

stas00 avatar Feb 23 '24 16:02 stas00

unstale, this is still unresolved.

Interesting. There is now an entry in the API docs but it appears it's not being indexed. I tried a few of the other listed functions and they're also not indexed. We'll probably need someone who knows about the doc builder to take a look, maybe @mishig25?

BenjaminBossan avatar Feb 26 '24 16:02 BenjaminBossan

cc @stevhliu as he's going through all our docs and being fantastic 🤗

muellerzr avatar Feb 26 '24 19:02 muellerzr

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

github-actions[bot] avatar Mar 22 '24 15:03 github-actions[bot]

unstale, this is still unresolved.

stas00 avatar Mar 22 '24 15:03 stas00

Will get this resolved today 🤗

muellerzr avatar Mar 22 '24 15:03 muellerzr