Mongoku icon indicating copy to clipboard operation
Mongoku copied to clipboard

Document Link Missing HREF

Open deckar01 opened this issue 3 years ago • 0 comments

Issue

The collection view has a href="#" stub for document ID links. Navigation is handled by a JavaScript click event. This breaks the UX of copying links or opening them in a new tab.

Background

https://github.com/huggingface/Mongoku/blob/d366b70254c3ca7a768f898c139c6b73337fd308/app/src/app/components/pretty-json/pretty-json.component.html#L5

https://github.com/huggingface/Mongoku/blob/d366b70254c3ca7a768f898c139c6b73337fd308/app/src/app/components/pretty-json/pretty-json.component.ts#L131-L134

https://github.com/huggingface/Mongoku/blob/d366b70254c3ca7a768f898c139c6b73337fd308/app/src/app/pages/explore/explore.component.ts#L125-L132

Proposal

Use a routerLink directive in pretty-json.component.html.

deckar01 avatar Feb 01 '22 15:02 deckar01