Mongoku icon indicating copy to clipboard operation
Mongoku copied to clipboard

feat: read only mode

Open McPatate opened this issue 4 years ago • 4 comments

  • Added env variable to specify to run Mongoku in read only mode or not
    • Read only is handled by a middleware that will return 401 on update / insert / delete routes
  • bumped most dependencies' versions and fixed breaking changes

McPatate avatar Jan 10 '22 16:01 McPatate

Notes :

  • I think Dark mode is kind of broken (buttons don't change to white and hover doesn't go to white either)
  • There could be a better a way to make UI clearer when mongoku is running in read only mode, editing is quite unclear (but doesn't work as intended)

McPatate avatar Jan 10 '22 16:01 McPatate

wasn't it better to just implement read-only and not upgrade dependencies? (to limit breaking changes and small UI regressions)

Well I couldn't start Mongoku even with the Docker image (tried pinning node base img version to 12, 14 & 16). So I thought it may be good thing to upgrade everything since it's been 2 years and many things are deprecated.

I could've done a first PR with the bump and then started working on the read only mode after. I wanted to move fast, sry about that.

McPatate avatar Jan 17 '22 08:01 McPatate

I pushed a little update in the readme to document the new flag, I hope it's ok :)

Pierrci avatar Feb 09 '22 22:02 Pierrci

Thanks @Pierrci !

McPatate avatar Feb 10 '22 09:02 McPatate

Can we merge this? If we want to work on other issues, it's good to have deps updated :)

coyotte508 avatar Nov 22 '22 10:11 coyotte508

@n1t0 ok for you?

julien-c avatar Nov 22 '22 11:11 julien-c