raccoon
raccoon copied to clipboard
hugary1995
request from RR main
pull request to add several material and kernel source files as well as a benchmark problem for pressurized fracture.
Hi Roozbeh, I can finally work on this now -- sorry for taking so long. If you can give me write access to this branch, I can directly work on it.
You can see why the tests are failing by clicking on "details". For example, the Precheck fails because some files contain trailing white spaces. I think if you enforce the .clang-format in the root directory they should be gone. Although I'm not sure how to set it up in spy. There is also one file containing banned keywords.
Thanks, I will work on it today.
Roozbeh Rezakhani, PhD Postdoctoral Researcher Department of Mechanical Engineering and Material Science Duke University Durham, NC, USA Email: @.*** Cell: +1 224 204 4500
On Tue, Jul 27, 2021 at 7:25 AM Gary (Tianchen) Hu @.***> wrote:
You can see why the tests are failing by clicking on "details". For example, the Precheck fails because some files contain trailing white spaces. I think if you enforce the .clang-format in the root directory they should be gone. Although I'm not sure how to set it up in spy. There is also one file containing banned keywords.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hugary1995/raccoon/pull/78#issuecomment-887431867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKK4RAOIH2XZP4UI3MZ2JCDTZ2JRFANCNFSM45P4RHMQ .
Hi @rrezakhani, could you please remind me where we were on this? Are you just waiting for my changes? If so, let me know and I'll work on this. I would like to get this PR in soon so that I can start preparing that SoftwareX paper.
Hey Roozbeh, are you sure the gold file in your tutorial is correct? I ran the test but it is giving me diff.
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: ERROR:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: *****************************************************************
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: EXODIFF (Version: 2.90) Modified: 2018-02-15
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Authors: Richard Drake, [email protected]
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Greg Sjaardema, [email protected]
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Run on 2021/10/13 18:21:58 CST
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: *****************************************************************
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Reading first file ...
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Reading second file ...
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: FILE 1: /home/gary/projects/raccoon/tutorials/hydraulic_fracturing_SPF/gold/results.e
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Title: results.e
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Dim = 2, Blocks = 1, Nodes = 1681, Elements = 1600, Nodesets = 4, Sidesets = 4
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Vars: Global = 4, Nodal = 5, Element = 29, Nodeset = 0, Sideset = 0, Times = 2
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: FILE 2: /home/gary/projects/raccoon/tutorials/hydraulic_fracturing_SPF/results.e
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Title: results.e
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Dim = 2, Blocks = 1, Nodes = 441, Elements = 400, Nodesets = 4, Sidesets = 4
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Vars: Global = 4, Nodal = 5, Element = 29, Nodeset = 0, Sideset = 0, Times = 2
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: exodiff: ERROR: .. Number of nodes doesn't agree.
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: exodiff: ERROR: .. Number of elements doesn't agree.
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: exodiff: Files are different
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: ################################################################################
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Tester failed, reason: EXODIFF
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture:
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture ............................ [FINISHED] FAILED (EXODIFF)
Hey Roozbeh, are you sure the gold file in your tutorial is correct? I ran the test but it is giving me diff.
tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: ERROR: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: ***************************************************************** tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: EXODIFF (Version: 2.90) Modified: 2018-02-15 tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Authors: Richard Drake, [email protected] tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Greg Sjaardema, [email protected] tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Run on 2021/10/13 18:21:58 CST tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: ***************************************************************** tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Reading first file ... tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Reading second file ... tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: FILE 1: /home/gary/projects/raccoon/tutorials/hydraulic_fracturing_SPF/gold/results.e tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Title: results.e tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Dim = 2, Blocks = 1, Nodes = 1681, Elements = 1600, Nodesets = 4, Sidesets = 4 tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Vars: Global = 4, Nodal = 5, Element = 29, Nodeset = 0, Sideset = 0, Times = 2 tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: FILE 2: /home/gary/projects/raccoon/tutorials/hydraulic_fracturing_SPF/results.e tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Title: results.e tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Dim = 2, Blocks = 1, Nodes = 441, Elements = 400, Nodesets = 4, Sidesets = 4 tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Vars: Global = 4, Nodal = 5, Element = 29, Nodeset = 0, Sideset = 0, Times = 2 tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: exodiff: ERROR: .. Number of nodes doesn't agree. tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: exodiff: ERROR: .. Number of elements doesn't agree. tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: exodiff: Files are different tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: ################################################################################ tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: Tester failed, reason: EXODIFF tutorials/hydraulic_fracturing_SPF.hydraulic_fracture: tutorials/hydraulic_fracturing_SPF.hydraulic_fracture ............................ [FINISHED] FAILED (EXODIFF)
Sorry my bad, it is fixed. It passes the test here.
[biot_coefficient]
type = ADDerivativeParsedMaterial
f_name = alpha
material_property_names = 'alpha0'
args = 'd'
function = 'alpha0'
derivative_order = 1
[]
Just wanted to make sure this is what you meant: is your biot coefficient always the same as the intact biot coefficient?
I think I've made most of the changes I want. Just two more questions:
- Do you still need the four classes I mentioned above that aren't being used anywhere? If you need them, we'll have to think of test cases for them. Otherwise, I'll remove them.
- It seems that you've removed all the fatigue stuff. Did you hand them over to Yuanchen? Or do you want to make them into another PR?
I think I've made most of the changes I want. Just two more questions:
- Do you still need the four classes I mentioned above that aren't being used anywhere? If you need them, we'll have to think of test cases for them. Otherwise, I'll remove them.
- It seems that you've removed all the fatigue stuff. Did you hand them over to Yuanchen? Or do you want to make them into another PR?
Those classes are used for two-phase flow simulations. I wanted to add them in the next pull request. I missed to remove those classes. Please remove them from this pull request. I wanted to add fatigue to next pull request as well, but I can actually do it for this one. I will add that with the relevant test and tutorial today.
Gary, I removed those unnecessary source files and tried to push, but it says there are things that have been done on github: To github.com:rrezakhani/raccoon.git ! [rejected] RRmain -> RRmain (fetch first) error: failed to push some refs to '[email protected]:rrezakhani/raccoon.git' hint: Updates were rejected because the remote contains work that you do hint: not have locally. This is usually caused by another repository pushing hint: to the same ref. You may want to first integrate the remote changes hint: (e.g., 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Have you done some modifications?
[biot_coefficient] type = ADDerivativeParsedMaterial f_name = alpha material_property_names = 'alpha0' args = 'd' function = 'alpha0' derivative_order = 1 []Just wanted to make sure this is what you meant: is your biot coefficient always the same as the intact biot coefficient?
In this specific simulation, biot coefficient is not changing. But it can be a function of damage in general. So I decided to keep this format. We can define a simple parameter for this specific example if you want.
Gary, I will add fatigue and multiphase flow files in the next PR. Let's finalize this one.
Gary, I removed those unnecessary source files and tried to push, but it says there are things that have been done on github: To github.com:rrezakhani/raccoon.git ! [rejected] RRmain -> RRmain (fetch first) error: failed to push some refs to '[email protected]:rrezakhani/raccoon.git' hint: Updates were rejected because the remote contains work that you do hint: not have locally. This is usually caused by another repository pushing hint: to the same ref. You may want to first integrate the remote changes hint: (e.g., 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details.
Have you done some modifications?
Yes, I have made several modifications. Can you do a git fetch then rebase your work on top of the remote head?
Sorry for the late reply -- I was taking vacation for the last two weeks.
I suspect that you may encounter several conflicts when trying to do the rebase. If you want we can meet via zoom and look at it together.