scikit-spectra icon indicating copy to clipboard operation
scikit-spectra copied to clipboard

Published 20 hours ago • verified publisher icon hugadams

COMPAT: pandas 0.15.0

Open jreback opened this issue 10 years ago • 3 comments

@hugadams heads up

pandas 0.15.0 refactors Index to no longer inherit from ndarray (releasing prob end of sept 2014)

See here

I see that you are inheriting from Float64Index (pyuuvis.core.abcindex), so you might need to make some changes.

jreback avatar Aug 14 '14 21:08 jreback

Thanks for the heads up! Will the pandas object behave like a normal python object, or will there be nuances do you think?

On Thu, Aug 14, 2014 at 5:27 PM, jreback [email protected] wrote:

@hugadams https://github.com/hugadams heads up

pandas 0.15.0 refactors Index to no longer inherit from ndarray (releasing prob end of sept 2014)

See here http://pandas-docs.github.io/pandas-docs-travis/whatsnew.html#whatsnew-0150-refactoring

I see that you are inheriting from Float64Index (pyuuvis.core.abcindex), so you might need to make some changes.

— Reply to this email directly or view it on GitHub https://github.com/hugadams/pyuvvis/issues/98.

Adam Hughes Physics Ph.D Candidate George Washington University

hughesadam87 avatar Aug 14 '14 21:08 hughesadam87

Yes, its almost 100% compat (just unpickles in a slightly different manner).However since you are sub-classing the __new__ signature is slightly different (meaning that data is now required, was optional before).

Also sub-class is easier in that you don't need to use views (so you will have to change that in your code).

jreback avatar Aug 14 '14 21:08 jreback

Thanks. I'm only subclassing new based on the info I read about subclassing a numpy array. I must admit I don't know much about it; I just followed a cooking recipe. Will be glad to get rid of it honestly, although must admit I'm a bit disappointed I didn't just procrastinate on this one and wait until 0.15!

On Thu, Aug 14, 2014 at 5:44 PM, jreback [email protected] wrote:

Yes, its almost 100% compat (just unpickles in a slightly different manner).However since you are sub-classing the new signature is slightly different (meaning that data is now required, was optional before).

Also sub-class is easier in that you don't need to use views (so you will have to change that in your code).

— Reply to this email directly or view it on GitHub https://github.com/hugadams/pyuvvis/issues/98#issuecomment-52249220.

Adam Hughes Physics Ph.D Candidate George Washington University

hughesadam87 avatar Aug 14 '14 21:08 hughesadam87