Hugues de Valon

Results 61 comments of Hugues de Valon

I think it's fine since we agreed in https://github.com/parallaxsecond/rust-cryptoki/issues/225 that the approach of passing `&mut Mechanism` should be done everywhere. Although I would have liked a bit more comments on...

Good point! Seems like a miss on our side because our `CInitializeArgs` [abstraction structure](https://docs.rs/cryptoki/latest/cryptoki/context/enum.CInitializeArgs.html) only actually implements the `flags` field of the same structure in the [specs](https://docs.oasis-open.org/pkcs11/pkcs11-base/v2.40/os/pkcs11-base-v2.40-os.html#_Toc416959692). It should probably...

Do you think it could be an error of the underlying PKCS11 implementation not returning those errors?

Thanks all and thank you @ivozeba for the summary ⭐ !

If you rebase and address @ionut-arm 's comments here we can easily get it merged :) !

Understood! Was a shame to not merge it after all your effort so pushed the same + the fix [here](https://github.com/parallaxsecond/rust-cryptoki/pull/239), hopefully we can get it merged soon and close the...

Thanks for putting it together! Does Rust run `test1` and `test2` as two different binaries? Or different threads? If that is the earlier, this could work as written in the...

Closing since the related issue has been closed. Thanks!

I am wondering if you are missing adding the target in the GitHub workflow files (in .github). Compare with PRs doing similar changes for example #166 and #190. The CI...

I think I managed to make it work in #251 !