huffmate icon indicating copy to clipboard operation
huffmate copied to clipboard

Dynamically sized `name` constructor arg for token impls

Open clabby opened this issue 3 years ago • 0 comments

Overview

Creates separate implementations of the token contracts that allow for a dynamically sized name via the new __CODECOPY_DYN_ARG builtin. Leaves symbol untouched because it will probably never be larger

TODO

  • Do we really need separate impls? Would be nice if we could edit how the name / symbol was stored depending on name length. At the moment, this would be pretty annoying due to constant overrides being more efficient for strings <= 32 bytes in length.
  • [ ] Tests!
  • [x] ERC721 edits
  • [x] ERC1155 edits
  • [ ] ERC20 edits
    • [ ] Update COMPUTE_DOMAIN_SEPARATOR to include the full name rather than the <= 32 bytes version.

clabby avatar Sep 23 '22 00:09 clabby