mlfinlab icon indicating copy to clipboard operation
mlfinlab copied to clipboard

OLPS unexpected output

Open sword134 opened this issue 4 years ago • 1 comments

Describe the bug If one has a dataset of the daily closing prices of lets say 30 stocks and add the latest closing prices for the new day, then the model trained on the dataset-newest entry will no longer yield the same returns. It wont even have the same weights, this is very concerning as 1 new data entry shouldn't be able to affect the previous days weights or returns, instead the OLPS algo should just trade accordingly

To Reproduce Steps to reproduce the behavior:

  1. Download dataset and remove the latest date entry
  2. Train any kind of OLPS model on this dataset
  3. Go back into your dataset and add the latest date entry to it again
  4. Run the OLPS model with the given hyperparameters and see it crush itself on the new data.

Expected behavior Adding a new date entry shouldn't affect previous days weights or returns.

sword134 avatar Aug 06 '20 13:08 sword134

Hello @Jackal08 @sword134 , I would like to contribute to this project by solving this issue. Can I?

Dhavin avatar Aug 18 '21 18:08 Dhavin