porymap icon indicating copy to clipboard operation
porymap copied to clipboard

Stop needlessly writing to generated files.

Open GriffinRichards opened this issue 7 months ago • 0 comments

Currently Porymap will write (but not read) the generated files include/constants/map_groups.h and include/constants/layouts.h. This is because the project repos do not generate these files before they are needed. After the changes in https://github.com/pret/pokeemerald/pull/1949 (and after they are synced to pokefirered and pokeruby), they are generated in time and Porymap doesn't need to write them anymore.

Given that this is a breaking change (if Porymap stops writing them users will need the changes in that PR) and that Porymap continuing to write the generated files is harmless, this should wait to be fixed alongside a breaking change of more consequence.

GriffinRichards avatar Nov 20 '23 18:11 GriffinRichards