HubSpot.NET icon indicating copy to clipboard operation
HubSpot.NET copied to clipboard

Remove HubSpot.NET.Core.ReflectionExtensions

Open Psypher9 opened this issue 5 years ago • 3 comments

The ReflectionExtensions class does not have any references outside of it self. Since v1 will be changing the serialization strategy/methodology entirely, these might not be needed at all.

Thoughts?

Psypher9 avatar Oct 24 '18 16:10 Psypher9

Seems to make sense to me - although might be worth holding off until we've figured out #37 and how we'll be supporting custom models going forwards, as that might use some of the reflection code?

clarkd avatar Nov 05 '18 16:11 clarkd

Well, I tracked down all of the references and there currently aren't any and all of these extensions were previously used in the now deprecated RequestSerializer and RequestDataConverter.

Psypher9 avatar Nov 05 '18 16:11 Psypher9

@Psypher9 I just meant that we might still need some of that code given that the custom models don't work properly right now? Happy to remove if it's still unused after we've figured that out!

clarkd avatar Nov 05 '18 16:11 clarkd