hubot icon indicating copy to clipboard operation
hubot copied to clipboard

Published 20 hours ago • verified publisher icon hubotio

Basic auth for HTTP Listener broken

Open pcunning opened this issue 6 years ago • 2 comments

When trying to use basic auth with the Express HTTP Listener (by setting EXPRESS_USER/EXPRESS_PASSWORD) Hubot crashes with the following error because basicAuth is not available in Express 4.x.

TypeError: express.basicAuth is not a function
    at Robot.setupExpress (./node_modules/hubot/src/robot.js:440:23)

https://github.com/hubotio/hubot/blob/85284750c878205aeae7338513961b29f0a1d18f/src/robot.js#L440

The version of Express Hubot uses was upgraded in #1453 and released in 3.1.0 breaking this feature.

pcunning avatar Oct 07 '18 05:10 pcunning

I encountered the same problem today, could the fix #1470 be merged?

MingStar avatar Mar 27 '20 03:03 MingStar

Or is basic auth not recommended?

MingStar avatar Mar 27 '20 03:03 MingStar