dynamic-spatial-filtering icon indicating copy to clipboard operation
dynamic-spatial-filtering copied to clipboard

Published 20 hours ago • verified publisher icon hubertjb

Little Finding

Open anthonyromyn opened this issue 3 years ago • 2 comments

Hey everyone,

Really cool package, very excited to use it. One little thing I found: braindecode naming conventions changed a bit in the new v0.6.0 release, which causes a few incompatibilities with the current package.

So for anyone wishing to use, install the previous braindecode version (v0.5.1) for everything to work smoothly. This is perhaps easiest by changing the last line in requirements.txt from https://api.github.com/repos/braindecode/braindecode/zipball/master to https://github.com/braindecode/braindecode/archive/refs/tags/0.5.1.zip.

Best, Anthony

anthonyromyn avatar May 27 '22 20:05 anthonyromyn

Thanks @anthonyromyn for testing out the repo and for reporting this! I've updated the code so that it is compatible with the latest version of braindecode, please let me know if that works for you.

hubertjb avatar May 30 '22 04:05 hubertjb

Awesome @hubertjb yeah it works great, thanks! Another random little thing I've come across in case it's helpful: for the option DATASET=pc18_hundred_files to work, train.py line 210 is missing the option:

choices=['sleep_physionet', 'pc18', 'pc18_debug'], changed to choices=['sleep_physionet', 'pc18', 'pc18_debug', 'pc18_hundred_files'],

Best, Anthony

anthonyromyn avatar May 31 '22 17:05 anthonyromyn