github-api
github-api copied to clipboard
Refactor pagination
Description
Before submitting a PR:
- [ ] Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
- [ ] Add JavaDocs and other comments explaining the behavior.
- [ ] When adding or updating methods that fetch entities, add
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest . - [ ] Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
- [ ] Run
mvn -D enable-ci clean install site "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"locally. If this command doesn't succeed, your change will not pass CI. - [ ] Push your changes to a branch other than
main. You will create your PR from that branch.
When creating a PR:
- [ ] Fill in the "Description" above with clear summary of the changes. This includes:
- [ ] If this PR fixes one or more issues, include "Fixes #
" lines for each issue. - [ ] Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
- [ ] If this PR fixes one or more issues, include "Fixes #
- [ ] All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
- [ ] Enable "Allow edits from maintainers".
Codecov Report
:x: Patch coverage is 99.57806% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 85.34%. Comparing base (b1de32d) to head (8b81765).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../java/org/kohsuke/github/GHCommitFileIterable.java | 88.88% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #2099 +/- ##
============================================
+ Coverage 85.02% 85.34% +0.31%
- Complexity 2496 2527 +31
============================================
Files 237 235 -2
Lines 7353 7280 -73
Branches 388 373 -15
============================================
- Hits 6252 6213 -39
+ Misses 871 851 -20
+ Partials 230 216 -14
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.