github-api icon indicating copy to clipboard operation
github-api copied to clipboard

Extract `parseWaitTime` method to shared utility

Open bitwiseman opened this issue 1 year ago • 3 comments

GitHubAbuseLimitHander and GitHubRateLimitHandler both implement parseWaitTime. Most of the code is the same and could also be useful to consumers of this library.

Extract parseWaitTime to a utility class and consider exposing as public.

bitwiseman avatar Oct 14 '24 17:10 bitwiseman

I was thinking of trying to work on this issue.

I would like to refactor the parseWaitTime method from both GitHubAbuseLimitHandler and GitHubRateLimitHandler into a utility class and potentially make it public for reuse. If that's okay with you, would it be alright for me to go ahead and try this approach? Please let me know if you have any concerns or suggestions.

choichanhyeok avatar Nov 27 '24 03:11 choichanhyeok

@bitwiseman seman Hi, I am a beginner and I have a question regarding this issue. Is it necessary to create a new utility class to extract the parseWaitTime method, or could we solve this problem in another way? Thank you!

shivangi-jindal avatar Dec 28 '24 07:12 shivangi-jindal

@bitwiseman seman Hi, I am a beginner and I have a question regarding this issue. Is it necessary to create a new utility class to extract the parseWaitTime method, or could we solve this problem in another way? Thank you!

What other way would you like to solve it?

bitwiseman avatar Jan 02 '25 22:01 bitwiseman