github-api
github-api copied to clipboard
Allow query parameters for listInstallations query
Description
Added a change to allow the option to pass in the since parameter per https://developer.github.com/v3/apps/#list-installations.
Before submitting a PR:
- [x] Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
- [x] Add JavaDocs and other comments explaining the behavior.
- [x] When adding or updating methods that fetch entities, add
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest . - [x] Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
- [x] Run
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI. - [x] Push your changes to a branch other than
main. You will create your PR from that branch.
When creating a PR:
- [x] Fill in the "Description" above with clear summary of the changes. This includes:
- [x] If this PR fixes one or more issues, include "Fixes #
" lines for each issue. - [x] Provide links to relevant documentation on https://docs.github.com/en/rest where possible. If not including links, explain why not.
- [x] If this PR fixes one or more issues, include "Fixes #
- [x] All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
- [x] Enable "Allow edits from maintainers".
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.69%. Comparing base (
a1499d7) to head (2ee0bcc). Report is 7 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1748 +/- ##
=========================================
Coverage 80.69% 80.69%
- Complexity 2330 2332 +2
=========================================
Files 220 220
Lines 7049 7050 +1
Branches 372 373 +1
=========================================
+ Hits 5688 5689 +1
Misses 1128 1128
Partials 233 233
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.