Add GHIssue#queryComments, with a since() filter
Description
Relevant documentation: https://docs.github.com/en/rest/issues/comments#list-issue-comments
This particular endpoint was already exposed through listComments, but that method doesn't allow setting the since filter, which filters out comments last created/updated before a given date.
I fixed that by introducing a new queryComments method that works similarly to org.kohsuke.github.GHRepository#queryIssues, though it exposes only one filter (the only one available at the moment): since.
Before submitting a PR:
- [X] Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
- [X] Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
- [X] Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
- [X] Run
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI. - [X] Push your changes to a branch other than
main. You will create your PR from that branch.
When creating a PR:
- [X] Fill in the "Description" above with clear summary of the changes. This includes:
- [X] If this PR fixes one or more issues, include "Fixes #
" lines for each issue. - [X] Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
- [X] If this PR fixes one or more issues, include "Fixes #
- [X] All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
- [x] Enable "Allow edits from maintainers".
Codecov Report
Base: 78.95% // Head: 78.98% // Increases project coverage by +0.02% :tada:
Coverage data is based on head (
a628b93) compared to base (319e943). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #1524 +/- ##
============================================
+ Coverage 78.95% 78.98% +0.02%
- Complexity 2129 2134 +5
============================================
Files 204 205 +1
Lines 6463 6472 +9
Branches 362 362
============================================
+ Hits 5103 5112 +9
Misses 1148 1148
Partials 212 212
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/main/java/org/kohsuke/github/GHIssue.java | 74.05% <100.00%> (+0.16%) |
:arrow_up: |
| ...org/kohsuke/github/GHIssueCommentQueryBuilder.java | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.