(feat) Support code-scanning API (Pt#1)
Description
Related issue - https://github.com/hub4j/github-api/issues/1133 New feature supporting GitHub code-scanning API.
As this is a big feature with multiple functions, breaking this into smaller PRs to reduce review effort. The functions supported in this PR are -
Codecov Report
Merging #1142 (c25f5b4) into main (5cd52d7) will decrease coverage by
0.59%. The diff coverage is81.92%.
:exclamation: Current head c25f5b4 differs from pull request most recent head 3f8f079. Consider uploading reports for the commit 3f8f079 to get more accurate results
@@ Coverage Diff @@
## main #1142 +/- ##
============================================
- Coverage 78.22% 77.62% -0.60%
+ Complexity 2073 1933 -140
============================================
Files 201 194 -7
Lines 6341 6083 -258
Branches 357 331 -26
============================================
- Hits 4960 4722 -238
+ Misses 1172 1159 -13
+ Partials 209 202 -7
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...rg/kohsuke/github/GHCodeScanningAlertInstance.java | 70.58% <70.58%> (ø) |
|
| ...n/java/org/kohsuke/github/GHCodeScanningAlert.java | 74.07% <74.07%> (ø) |
|
| src/main/java/org/kohsuke/github/GHRepository.java | 68.71% <88.88%> (+0.66%) |
:arrow_up: |
| ...e/github/GHCodeScanningAlertInstancesIterable.java | 92.30% <92.30%> (ø) |
|
| ...g/kohsuke/github/GHCodeScanningAlertsIterable.java | 93.33% <93.33%> (ø) |
|
| ...a/org/kohsuke/github/GHCodeScanningAlertState.java | 100.00% <100.00%> (ø) |
|
| ...main/java/org/kohsuke/github/RateLimitHandler.java | 69.23% <0.00%> (-9.72%) |
:arrow_down: |
| ...ain/java/org/kohsuke/github/AbuseLimitHandler.java | 69.23% <0.00%> (-9.72%) |
:arrow_down: |
| ...ava/org/kohsuke/github/GHContentSearchBuilder.java | 73.91% <0.00%> (-6.86%) |
:arrow_down: |
| ...n/java/org/kohsuke/github/GHPullRequestReview.java | 65.78% <0.00%> (-4.22%) |
:arrow_down: |
| ... and 47 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 06f2f8b...3f8f079. Read the comment docs.
@akashRindhe We value contributions like this. I apologize for the delay reviewing and merging. We've seen some high priority issues come in and I personally have other work I've needed to focus on. I will get to this as soon as I can.
@ravingbool Do you think you could do the testing to get this in shape to merge? (You reacted 👍 above, so I thought it might be of interest to you.)
@bitwiseman I'm sorry, I was on vacation, yes, I think I can try to write tests for it soon.
@akashRindhe @ravingbool @jj-crypto I got this back to runnable state.
Converted to Draft as it is not ready for review.
hey @bitwiseman / @akashRindhe where does this stand? i could use this functionality at the day job and am happy to pick up on it.
@jgangemi
hey @bitwiseman / @akashRindhe where does this stand? i could use this functionality at the day job and am happy to pick up on it.
What's needed is a review of all messages regarding lines not covered from code coverage and fix or comment on why they are not covered.
ok - i've created a new branch to work on. i'll push something up for some initial feedback.
ok - i've created a new branch to work on. i'll push something up for some initial feedback.
Just open a new PR. That will get you all the checking behavior that you're going to need. Just keep @akashRindhe's original commits and build on top of them. That way they still get the credit for their work when the PR is merged.