terraform-provider-huaweicloud icon indicating copy to clipboard operation
terraform-provider-huaweicloud copied to clipboard

fix: feat(apig): new parameters supported for custom authorizer resource

Open Lance52259 opened this issue 9 months ago • 2 comments

What this PR does / why we need it: The parameter authorizer_uri is no longer support the function version, and they are provide authorizer_version to support it. It is a breaking changes for API users, and it cause the creation of the provider resource failed.

Which issue this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged) fixes #xxx

Special notes for your reviewer:

Release note:

1. new version parameter supported and fix the compare error.
2. new parameters are supported for custom authorizer.

PR Checklist

  • [x] Tests added/passed.
  • [x] Documentation updated.
  • [x] Schema updated.

Acceptance Steps Performed

PENDING

Lance52259 avatar May 06 '24 07:05 Lance52259

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

github-ci-robot avatar May 06 '24 07:05 github-ci-robot

make testacc TEST='./huaweicloud/services/acceptance/apig' TESTARGS='-run=TestAccApi_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/apig -v -run=TestAccApi_basic -timeout 360m -parallel 4
=== RUN   TestAccApi_basic
=== PAUSE TestAccApi_basic
=== CONT  TestAccApi_basic
--- PASS: TestAccApi_basic (655.15s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig      655.188s

Lance52259 avatar May 07 '24 08:05 Lance52259

/lgtm

deer-hang avatar May 16 '24 08:05 deer-hang