terraform-provider-huaweicloud icon indicating copy to clipboard operation
terraform-provider-huaweicloud copied to clipboard

refactor(cdn): make ForceNew of name configurable

Open Jason-Zhang9309 opened this issue 10 months ago • 5 comments

What this PR does / why we need it:

Which issue this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged) fixes #xxx

Special notes for your reviewer:

Release note:

1. add common func FlexibleForceNew to make the ForceNew action configurable
2. use this func in cdn domain resource as an example

PR Checklist

  • [x] Tests added/passed.
  • [ ] Documentation updated.
  • [x] Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/cdn' TESTARGS='-run TestAccCdnDomain_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cdn -v -run TestAccCdnDomain_basic -timeout 360m -parallel 4
=== RUN   TestAccCdnDomain_basic
=== PAUSE TestAccCdnDomain_basic
=== CONT  TestAccCdnDomain_basic
--- PASS: TestAccCdnDomain_basic (704.94s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cdn       704.991s

Jason-Zhang9309 avatar Apr 17 '24 02:04 Jason-Zhang9309

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Jason-Zhang9309

The full list of commands accepted by this bot can be found here.

github-ci-robot avatar Apr 17 '24 02:04 github-ci-robot

You are the author and cannot comment /lgtm

github-ci-robot avatar Apr 17 '24 09:04 github-ci-robot

/hold

Jason-Zhang9309 avatar Apr 18 '24 08:04 Jason-Zhang9309

Rename file name from forceNew.go to force_new.go

deer-hang avatar Apr 18 '24 08:04 deer-hang

Add test cases for changes in the config directory.

deer-hang avatar Apr 18 '24 09:04 deer-hang

This PR needs rebase.

github-ci-robot avatar May 22 '24 06:05 github-ci-robot

/hold cancel

Jason-Zhang9309 avatar Jun 14 '24 03:06 Jason-Zhang9309

/hold cancel

Jason-Zhang9309 avatar Jun 14 '24 03:06 Jason-Zhang9309

/lgtm

houpeng80 avatar Jun 14 '24 08:06 houpeng80