terraform-provider-huaweicloud icon indicating copy to clipboard operation
terraform-provider-huaweicloud copied to clipboard

feat(workspace/service): add new resource support

Open Lance52259 opened this issue 2 years ago • 5 comments

What this PR does / why we need it: Add new resource support: huaweicloud_workspace_service Using this resource, we can subscribe the workspace service and connect to the AD domain.

Which issue this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged) fixes #xxx

Special notes for your reviewer:

Release note:

1. support a new resource for workspace service.

PR Checklist

  • [x] Tests added/passed.
  • [x] Documentation updated.
  • [x] Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/workspace' TESTARGS='-run=TestAccService_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/workspace -v -run=TestAccService_basic -timeout 360m -parallel 4
=== RUN   TestAccService_basic
=== PAUSE TestAccService_basic
=== CONT  TestAccService_basic
--- PASS: TestAccService_basic (626.13s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 626.220s
make testacc TEST='./huaweicloud/services/acceptance/workspace' TESTARGS='-run=TestAccService_localAD'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/workspace -v -run=TestAccService_localAD -timeout 360m -parallel 4
=== RUN   TestAccService_localAD
=== PAUSE TestAccService_localAD
=== CONT  TestAccService_localAD
--- PASS: TestAccService_localAD (612.11s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 612.211s

Lance52259 avatar Oct 20 '22 07:10 Lance52259

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 20 '22 07:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 20 '22 07:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 20 '22 09:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 20 '22 12:10 github-actions[bot]

make testacc TEST='./huaweicloud/services/acceptance/workspace' TESTARGS='-run=TestAccService_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/workspace -v -run=TestAccService_basic -timeout 360m -parallel 4
=== RUN   TestAccService_basic
=== PAUSE TestAccService_basic
=== CONT  TestAccService_basic
--- PASS: TestAccService_basic (615.21s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 615.282s
make testacc TEST='./huaweicloud/services/acceptance/workspace' TESTARGS='-run=TestAccService_localAD'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/workspace -v -run=TestAccService_localAD -timeout 360m -parallel 4
=== RUN   TestAccService_localAD
=== PAUSE TestAccService_localAD
=== CONT  TestAccService_localAD
--- PASS: TestAccService_localAD (618.63s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 618.721s

Lance52259 avatar Oct 20 '22 12:10 Lance52259

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 21 '22 09:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 21 '22 09:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 21 '22 09:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 21 '22 10:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 24 '22 03:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 24 '22 03:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 24 '22 03:10 github-actions[bot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 24 '22 07:10 github-actions[bot]

/lgtm

Jason-Zhang9309 avatar Oct 24 '22 07:10 Jason-Zhang9309

/lgtm

hmbig2 avatar Oct 25 '22 01:10 hmbig2

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions[bot] avatar Oct 25 '22 03:10 github-actions[bot]

make testacc TEST='./huaweicloud/services/acceptance/workspace' TESTARGS='-run=TestAccService_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/workspace -v -run=TestAccService_basic -timeout 360m -parallel 4
=== RUN   TestAccService_basic
=== PAUSE TestAccService_basic
=== CONT  TestAccService_basic
--- PASS: TestAccService_basic (604.78s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 604.871s

Lance52259 avatar Oct 25 '22 03:10 Lance52259

/lgtm

ShiChangkuo avatar Oct 25 '22 03:10 ShiChangkuo