terraform-provider-huaweicloud icon indicating copy to clipboard operation
terraform-provider-huaweicloud copied to clipboard

refactor(eip/list): set enterprise_project_id to all_granted_eps if it's not specified

Open Jason-Zhang9309 opened this issue 2 years ago • 2 comments

What this PR does / why we need it:

set enterprise_project_id to all_granted_eps if it's not specified

Which issue this PR fixes: (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged) fixes #xxx

Special notes for your reviewer:

Release note:

set enterprise_project_id to all_granted_eps if it's not specified

PR Checklist

  • [ ] Tests added/passed.
  • [ ] Documentation updated.
  • [ ] Schema updated.

Acceptance Steps Performed

make testacc TEST='./huaweicloud/services/acceptance/eip' TESTARGS='-run TestAccEIPAssociate_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/eip -v -run TestAccEIPAssociate_basic -timeout 360m -parallel 4
=== RUN   TestAccEIPAssociate_basic
=== PAUSE TestAccEIPAssociate_basic
=== CONT  TestAccEIPAssociate_basic
--- PASS: TestAccEIPAssociate_basic (224.57s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/eip       224.693s

make testacc TEST='./huaweicloud' TESTARGS='-run TestAccComputeEIPAssociate_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccComputeEIPAssociate_basic -timeout 360m -parallel 4
=== RUN   TestAccComputeEIPAssociate_basic
=== PAUSE TestAccComputeEIPAssociate_basic
=== CONT  TestAccComputeEIPAssociate_basic
--- PASS: TestAccComputeEIPAssociate_basic (174.40s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       174.561s

make testacc TEST='./huaweicloud' TESTARGS='-run TestAccCCENodeV3_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccCCENodeV3_basic -timeout 360m -parallel 4
=== RUN   TestAccCCENodeV3_basic
=== PAUSE TestAccCCENodeV3_basic
=== CONT  TestAccCCENodeV3_basic
--- PASS: TestAccCCENodeV3_basic (865.67s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       865.770s

make testacc TEST='./huaweicloud' TESTARGS='-run TestAccComputeInstance_prePaid'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccComputeInstance_prePaid -timeout 360m -parallel 4
=== RUN   TestAccComputeInstance_prePaid
=== PAUSE TestAccComputeInstance_prePaid
=== CONT  TestAccComputeInstance_prePaid
--- PASS: TestAccComputeInstance_prePaid (172.70s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       172.809s

make testacc TEST='./huaweicloud/services/acceptance/mrs' TESTARGS='-run TestAccMrsMapReduceCluster_Eip_publicIp'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/mrs -v -run TestAccMrsMapReduceCluster_Eip_publicIp -timeout 360m -parallel 4
=== RUN   TestAccMrsMapReduceCluster_Eip_publicIp
=== PAUSE TestAccMrsMapReduceCluster_Eip_publicIp
=== CONT  TestAccMrsMapReduceCluster_Eip_publicIp
--- PASS: TestAccMrsMapReduceCluster_Eip_publicIp (792.22s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/mrs       792.379s

Jason-Zhang9309 avatar Aug 16 '22 09:08 Jason-Zhang9309

/lgtm

ShiChangkuo avatar Aug 23 '22 08:08 ShiChangkuo

run acceptance tests of huaweicloud/resource_huaweicloud_cce_node_v3_test.go:
=== RUN   TestAccCCENodeV3_basic
=== PAUSE TestAccCCENodeV3_basic
=== RUN   TestAccCCENodeV3_auto_assign_eip
=== PAUSE TestAccCCENodeV3_auto_assign_eip
=== RUN   TestAccCCENodeV3_existing_eip
=== PAUSE TestAccCCENodeV3_existing_eip
=== RUN   TestAccCCENodeV3_volume_extendParams
=== PAUSE TestAccCCENodeV3_volume_extendParams
=== RUN   TestAccCCENodeV3_data_volume_encryption
=== PAUSE TestAccCCENodeV3_data_volume_encryption
=== RUN   TestAccCCENodeV3_prePaid
=== PAUSE TestAccCCENodeV3_prePaid
=== RUN   TestAccCCENodeV3_password
=== PAUSE TestAccCCENodeV3_password
=== RUN   TestAccCCENodeV3_storage
=== PAUSE TestAccCCENodeV3_storage
=== CONT  TestAccCCENodeV3_basic
=== CONT  TestAccCCENodeV3_data_volume_encryption
    provider_test.go:141: This environment does not support KMS tests
--- SKIP: TestAccCCENodeV3_data_volume_encryption (0.00s)
=== CONT  TestAccCCENodeV3_prePaid
=== CONT  TestAccCCENodeV3_storage
=== CONT  TestAccCCENodeV3_password
    resource_huaweicloud_cce_node_v3_test.go:199: Step 1/1 error: Error running apply: exit status 1
        
        Error: remote-exec provisioner error
        
          with huaweicloud_cce_node.test,
          on terraform_plugin_test.tf line 67, in resource "huaweicloud_cce_node" "test":
          67:   provisioner "remote-exec" {
        
        timeout - last error: SSH authentication failed ([email protected]:22):
        ssh: handshake failed: ssh: unable to authenticate, attempted methods [none
        password], no supported methods remain
--- PASS: TestAccCCENodeV3_storage (824.15s)
=== CONT  TestAccCCENodeV3_existing_eip
--- PASS: TestAccCCENodeV3_basic (877.15s)
=== CONT  TestAccCCENodeV3_volume_extendParams
--- FAIL: TestAccCCENodeV3_password (943.62s)
=== CONT  TestAccCCENodeV3_auto_assign_eip
=== CONT  TestAccCCENodeV3_prePaid
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: Error deleting Huaweicloud VPC 54af2bab-b589-4ef3-a311-d7221a7f7512: timeout while waiting for state to become 'DELETED' (timeout: 3m0s)
        
--- FAIL: TestAccCCENodeV3_prePaid (1405.16s)
--- PASS: TestAccCCENodeV3_existing_eip (869.91s)
--- PASS: TestAccCCENodeV3_volume_extendParams (830.81s)
--- PASS: TestAccCCENodeV3_auto_assign_eip (928.04s)
FAIL
FAIL	github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud	1871.727s
FAIL
run acceptance tests of huaweicloud/resource_huaweicloud_compute_eip_associate_test.go:
=== RUN   TestAccComputeEIPAssociate_basic
=== PAUSE TestAccComputeEIPAssociate_basic
=== RUN   TestAccComputeEIPAssociate_fixedIP
=== PAUSE TestAccComputeEIPAssociate_fixedIP
=== RUN   TestAccComputeEIPAssociate_bandwidth
=== PAUSE TestAccComputeEIPAssociate_bandwidth
=== CONT  TestAccComputeEIPAssociate_basic
=== CONT  TestAccComputeEIPAssociate_bandwidth
=== CONT  TestAccComputeEIPAssociate_fixedIP
--- PASS: TestAccComputeEIPAssociate_fixedIP (183.71s)
--- PASS: TestAccComputeEIPAssociate_basic (202.69s)
=== CONT  TestAccComputeEIPAssociate_bandwidth
    resource_huaweicloud_compute_eip_associate_test.go:253: Step 1/2 error: Error running apply: exit status 1
        
        Error: error waiting for EIP association to complete: timeout while waiting for state to become 'COMPLETED' (last state: 'STARTING', timeout: 10m0s)
        
          with huaweicloud_compute_eip_associate.test,
          on terraform_plugin_test.tf line 44, in resource "huaweicloud_compute_eip_associate" "test":
          44: resource "huaweicloud_compute_eip_associate" "test" {
        
--- FAIL: TestAccComputeEIPAssociate_bandwidth (808.64s)
FAIL
FAIL	github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud	808.700s
FAIL
run acceptance tests of huaweicloud/resource_huaweicloud_compute_instance_test.go:
=== RUN   TestAccComputeInstance_basic
=== PAUSE TestAccComputeInstance_basic
=== RUN   TestAccComputeInstance_disks
=== PAUSE TestAccComputeInstance_disks
=== RUN   TestAccComputeInstance_prePaid
=== PAUSE TestAccComputeInstance_prePaid
=== RUN   TestAccComputeInstance_tags
=== PAUSE TestAccComputeInstance_tags
=== RUN   TestAccComputeInstance_powerAction
=== PAUSE TestAccComputeInstance_powerAction
=== CONT  TestAccComputeInstance_basic
=== CONT  TestAccComputeInstance_tags
=== CONT  TestAccComputeInstance_powerAction
=== CONT  TestAccComputeInstance_prePaid
--- PASS: TestAccComputeInstance_prePaid (215.99s)
=== CONT  TestAccComputeInstance_disks
--- PASS: TestAccComputeInstance_basic (234.34s)
--- PASS: TestAccComputeInstance_tags (389.91s)
--- PASS: TestAccComputeInstance_disks (301.47s)
=== CONT  TestAccComputeInstance_powerAction
    resource_huaweicloud_compute_instance_test.go:164: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
        
        (map[string]string) {
        }
        
        
        (map[string]string) (len=1) {
         (string) (len=25) "delete_eip_on_termination": (string) (len=4) "true"
        }
--- FAIL: TestAccComputeInstance_powerAction (581.06s)
FAIL
FAIL	github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud	581.124s
FAIL
run acceptance tests of huaweicloud/services/acceptance/apig/resource_huaweicloud_apig_instance_test.go:
=== RUN   TestAccApigInstanceV2_basic
=== PAUSE TestAccApigInstanceV2_basic
=== RUN   TestAccApigInstanceV2_egress
=== PAUSE TestAccApigInstanceV2_egress
=== RUN   TestAccApigInstanceV2_ingress
=== PAUSE TestAccApigInstanceV2_ingress
=== CONT  TestAccApigInstanceV2_basic
=== CONT  TestAccApigInstanceV2_ingress
=== CONT  TestAccApigInstanceV2_egress
=== CONT  TestAccApigInstanceV2_ingress
    resource_huaweicloud_apig_instance_test.go:133: Step 4/5 error: Error running apply: exit status 1
        
        Error: 1 error occurred:
        	* queried none results with 139.9.140.68
        
        
        
          with huaweicloud_apig_instance.test,
          on terraform_plugin_test.tf line 22, in resource "huaweicloud_apig_instance" "test":
          22: resource "huaweicloud_apig_instance" "test" {
        
--- PASS: TestAccApigInstanceV2_egress (571.55s)
--- FAIL: TestAccApigInstanceV2_ingress (574.96s)
=== CONT  TestAccApigInstanceV2_basic
    resource_huaweicloud_apig_instance_test.go:21: Step 2/3 error: Error running apply: exit status 1
        
        Error: Error deleting security group (409ff285-b706-45ab-b7f9-4564be418d34): timeout while waiting for state to become 'DELETED' (last state: 'ACTIVE', timeout: 10m0s)
        
--- FAIL: TestAccApigInstanceV2_basic (1075.37s)
FAIL
FAIL	github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/apig	1075.414s
FAIL
run acceptance tests of huaweicloud/services/acceptance/bms/resource_huaweicloud_bms_instance_test.go:
=== RUN   TestAccBmsInstance_basic
=== PAUSE TestAccBmsInstance_basic
=== CONT  TestAccBmsInstance_basic
    acceptance.go:160: HW_USER_ID must be set for BMS acceptance tests
--- SKIP: TestAccBmsInstance_basic (0.00s)
PASS
ok  	github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/bms	0.048s

[skipped] ./huaweicloud/services/acceptance/eip/resource_huaweicloud_vpc_eip_associate_test.go does not exist

run acceptance tests of huaweicloud/services/acceptance/mrs/resource_huaweicloud_mapreduce_cluster_test.go:
=== RUN   TestAccMrsMapReduceCluster_basic
=== PAUSE TestAccMrsMapReduceCluster_basic
=== RUN   TestAccMrsMapReduceCluster_keypair
=== PAUSE TestAccMrsMapReduceCluster_keypair
=== RUN   TestAccMrsMapReduceCluster_analysis
=== PAUSE TestAccMrsMapReduceCluster_analysis
=== RUN   TestAccMrsMapReduceCluster_stream
=== PAUSE TestAccMrsMapReduceCluster_stream
=== RUN   TestAccMrsMapReduceCluster_hybrid
=== PAUSE TestAccMrsMapReduceCluster_hybrid
=== RUN   TestAccMrsMapReduceCluster_custom_compact
=== PAUSE TestAccMrsMapReduceCluster_custom_compact
=== RUN   TestAccMrsMapReduceCluster_custom_seperate
=== PAUSE TestAccMrsMapReduceCluster_custom_seperate
=== RUN   TestAccMrsMapReduceCluster_custom_fullsize
=== PAUSE TestAccMrsMapReduceCluster_custom_fullsize
=== RUN   TestAccMrsMapReduceCluster_Eip_id
=== PAUSE TestAccMrsMapReduceCluster_Eip_id
=== RUN   TestAccMrsMapReduceCluster_Eip_publicIp
=== PAUSE TestAccMrsMapReduceCluster_Eip_publicIp
=== CONT  TestAccMrsMapReduceCluster_basic
=== CONT  TestAccMrsMapReduceCluster_custom_compact
    acceptance.go:174: HW_MAPREDUCE_CUSTOM must be set for acceptance tests:custom type cluster of map reduce
--- SKIP: TestAccMrsMapReduceCluster_custom_compact (0.00s)
=== CONT  TestAccMrsMapReduceCluster_Eip_publicIp
=== CONT  TestAccMrsMapReduceCluster_Eip_id
=== CONT  TestAccMrsMapReduceCluster_custom_fullsize
    acceptance.go:174: HW_MAPREDUCE_CUSTOM must be set for acceptance tests:custom type cluster of map reduce
--- SKIP: TestAccMrsMapReduceCluster_custom_fullsize (0.00s)
=== CONT  TestAccMrsMapReduceCluster_custom_seperate
    acceptance.go:174: HW_MAPREDUCE_CUSTOM must be set for acceptance tests:custom type cluster of map reduce
--- SKIP: TestAccMrsMapReduceCluster_custom_seperate (0.00s)
=== CONT  TestAccMrsMapReduceCluster_stream
--- PASS: TestAccMrsMapReduceCluster_Eip_id (801.70s)
=== CONT  TestAccMrsMapReduceCluster_hybrid
--- PASS: TestAccMrsMapReduceCluster_Eip_publicIp (801.85s)
=== CONT  TestAccMrsMapReduceCluster_analysis
--- PASS: TestAccMrsMapReduceCluster_basic (868.37s)
=== CONT  TestAccMrsMapReduceCluster_keypair
--- PASS: TestAccMrsMapReduceCluster_keypair (802.81s)
--- PASS: TestAccMrsMapReduceCluster_stream (1819.66s)
--- PASS: TestAccMrsMapReduceCluster_analysis (2312.81s)
--- PASS: TestAccMrsMapReduceCluster_hybrid (3764.18s)
PASS
ok  	github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/mrs	4565.927s

[summary] 4 failed in 6 resource acceptance tests

github-actions[bot] avatar Aug 23 '22 11:08 github-actions[bot]

/lgtm

ShiChangkuo avatar Aug 27 '22 06:08 ShiChangkuo