torch-srgan icon indicating copy to clipboard operation
torch-srgan copied to clipboard

Published 20 hours ago • verified publisher icon huangzehao

A general question

Open omrysendik opened this issue 7 years ago • 5 comments

Hi,

I may be missing something very obvious but I see that the adversarial loss is actually not implemented. Is this correct?

Thanks, Omry

omrysendik avatar Apr 29 '17 19:04 omrysendik

Hi, This code only provides the implementation of SRResNet. SRGAN is implemented but the result is not very good.

huangzehao avatar Apr 30 '17 03:04 huangzehao

What do you mean it is implemented? I do not see the adversarial loss.

omrysendik avatar Apr 30 '17 05:04 omrysendik

It's implemented, but I don't provide in this repo.

在 2017年4月30日，13:33，OmrySendik <[email protected]mailto:[email protected]> 写道：

What do you mean it is implemented? I do not see the adversarial loss.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/huangzehao/torch-srgan/issues/10#issuecomment-298212587, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANB22i3HPvVehAiPN0zYkcjSXruAoG5Cks5r1B0pgaJpZM4NMW1k.

huangzehao avatar Apr 30 '17 05:04 huangzehao

It is very misleading to say that it is implemented. I would change this comment.

omrysendik avatar Apr 30 '17 05:04 omrysendik

Sorry for my misleading information. I didn't provide the part of gan since the performance wasn't very good. I will share the codes if I can implement a good result. Thanks.

huangzehao avatar May 02 '17 08:05 huangzehao