huangyz0918
[UI] Full Dark Mode
Hey ^_^
I'm using your Moving theme and loved it, so I decided to make a Dark version of it to reduce eye restraint!
I also have several other fixes and improvements/Add-ons that I'm using and will create PRs for them separately.
If interested, you can see it in action here: ~https://vel-san.github.io/~ https://bleeding-action-man.github.io/
Thanks for your work!
Wow, cool, I love this theme @Vel-San ! Can you update a theme trigger in the _config.yml file? Current changes will overwrite the light theme, so I cannot merge it.
You can add an attribute like dark-mode: true in the under the moving label, and load the different css according to that, if you have any issues in this feature, I'm glad to help!
@huangyz0918 Thanks!
Yes of course, personally i wanted to make a button that alternates between dark/light mode. I didn't know about the trigger, i'll do it :) !
I didn't know about the trigger, i'll do it :) !
Since the Jekyll is a static blog framework, a dynamic button is inappropriate here. Actually it is a really simple feature, you can refer to the Liquid Language, that builds Jekyll theme.
~~@huangyz0918 Do you know if there's a way to override colors in scss based on the trigger BOOL in the _config ? Or can i override colors in the html ? will the classes take the new overridden variable? if not, i think i'll be duplicating each class into light and dark .. I feel this isn't the proper solution.~~
I'm so stupid! I don't know why i tried to make it so complex for nothing 😄 !
Issue should be fixed now. Default is Light theme!
Note: I still need to fix the difference between Dates and Post titles ( Grey and White / Grey and Black )
I'll release a fix soon :)
Done! I've fixed all mismatching colors. Previosly everything was set on text-color, i've changed it for better readability and eye-friendlly between Black/Grey/White.
Fixes applied on both Light and Dark modes. I also published them on my own version here as well
https://vel-san.github.io/