Truncate Regex Causes Infinite Loop

[jbasdf]

This commit adds no value attributes to the truncation process but also introduces an infinite loop. Running this regex: KEY_VALUE_REGEX = '([\w|-]+\s*(=\s*"[^"]")?\s)*' on an iframe with attributes with and without values will result in the process freezing. For example, this bit of code will result in the process locking: <iframe width="560" height="315" src="//www.youtube.com/embed/eFGolAT2l6c" frameborder="0" allowfullscreen></iframe>

The specific line that freezes is 205: selfClose = SELF_CLOSE_REGEX.exec(result);

This error can be reproduced by executing that line of code, having set the pertinent values, on the command line. I've also written a test to demonstrate the problem on this branch:

https://github.com/huang47/nodejs-html-truncate/compare/master...jbasdf:locking_bug

[mdevine82]

Wanted to bump this because its still an issue and another component I want to use relies on this library.

[kylefarris]

I'm actually experiencing this issue as well. A block of HTML I'm trying to truncate contains a Vimeo video embed and has attributes with no value so it's causing the process to lock up. :-(

[ex1st]

Hello @huang47, do you plan any updates? Thank you.

[thephucit]

Same issue, there is any solution?

[oferRounds]

same.. any solution?

[mhluska]

Same issue. Seems like this was reverted in 2017 though? https://github.com/huang47/nodejs-html-truncate/commit/be300c7d85a465c8838333c0c4c7092c72ac425a

@huang47 @pakmanlh can you please publish a 1.2.3 version? 🙏

[nop1984]

And seems like it still does, hangs on HTML with 3 P and one nested IMG

P.S. Surprising ppl still trying to make gold from plumbum parse HTML with regex