node-facenet icon indicating copy to clipboard operation
node-facenet copied to clipboard

Only store embedding & basic meta data for Face Instance when call toJSON

Open huan opened this issue 7 years ago • 3 comments

Store imageData separate, for better performance when calculating distance() for many cached faces.

huan avatar Nov 08 '17 18:11 huan

I would rather put the distance method on embedding and also add a serialization method on it rather than putting it only on the face class.

Scapal avatar Nov 20 '17 09:11 Scapal

@scapal good idea.

Would you like to send a pull request to show your idea?

huan avatar Nov 20 '17 10:11 huan

@zixia Yes I may have some time by the end of the week to do so.

Scapal avatar Nov 20 '17 13:11 Scapal