ember-google-map icon indicating copy to clipboard operation
ember-google-map copied to clipboard

Broken with Ember 2.0

Open erkie opened this issue 9 years ago • 12 comments

Running with Ember 2.0 throws this error when trying to build:

Assertion Failed: Using `{{view}}` or any path based on it ('templates/components/google-map.hbs' @ L5:C6) has been removed in Ember 2.0)

With the following bower config:

{
  "name": "projectname",
  "dependencies": {
    "ember": "2.0.0",
    "ember-cli-shims": "ember-cli/ember-cli-shims#0.0.3",
    "ember-cli-test-loader": "ember-cli-test-loader#0.1.3",
    "ember-data": "2.0.0-beta.2",
    "ember-load-initializers": "ember-cli/ember-load-initializers#0.1.5",
    "ember-qunit": "0.4.9",
    "ember-qunit-notifications": "0.0.7",
    "ember-resolver": "~0.1.18",
    "jquery": "^1.11.3",
    "loader.js": "ember-cli/loader.js#3.2.1",
    "qunit": "~1.18.0"
  }
}

erkie avatar Aug 26 '15 13:08 erkie

@erkie Hi, try this fork https://github.com/serho/ember-google-map.

serho avatar Sep 01 '15 14:09 serho

+1 please fix in main repo

TNAJanssen avatar Oct 13 '15 12:10 TNAJanssen

@serho it doesn't work

TNAJanssen avatar Oct 13 '15 12:10 TNAJanssen

Is there any plan of fixing this? Its stopping everyone from using this component with ember 2.0?

sheoranpranava91 avatar Nov 28 '15 11:11 sheoranpranava91

As an alternative you can use this package:

https://github.com/SamvelRaja/google-maps-addon

erkie avatar Nov 28 '15 11:11 erkie

I've implemented addon with slightly different approach, so you can try that too - https://github.com/asennikov/ember-g-map

asennikov avatar Dec 11 '15 09:12 asennikov

@asennikov really nice one! Awesome implementation

erkie avatar Dec 11 '15 13:12 erkie

@asennikov, that is the one approach I am slowly doing for my 1.0 version. It wasn't possible to do so before 1.13 (i.e. 2.0 features of ember). Badly I got no time to finish it quickly. It's a shame that forks have taken priority over PRs but at least it frees me from having this in mind :-)

huafu avatar Dec 11 '15 22:12 huafu

@huafu my first intention was to introduce PR for 1.13/2.0 migration of your project, but then things got ugly at my job and we needed solution that really works with 2.0 ember. I had no time to really understand how things are implemented here, plus it would have been almost complete rewrite, so I've quickly implemented my own (limited) version over weekend, extending it later with some minor features.

asennikov avatar Dec 13 '15 12:12 asennikov

Hey all!

I just want to get a feel for what is going on here... @huafu I completely agree with your statement It's a shame that forks have taken priority over PRs but that is just my own personal opinion and the reason is because new people like myself don't really know what the best branch to use is from this point.

@huafu when you say "It frees me from having this in my mind" does that mean that there is no intention to maintain this project? Are you advising us to go with @asennikov 's version?

mansona avatar Jan 18 '16 10:01 mansona

@asennikov I did not want to say you're right or wrong. If I had time to work on this, that's the way I'd have gone.

@mansona I'd love to say that I will get the time to update this project, but while it may happen, I don't know when. so yeah, go with @asennikov would be safer for your projects

huafu avatar Jan 19 '16 05:01 huafu

Thanks @huafu, I really appreciate the honesty :+1:

mansona avatar Jan 19 '16 10:01 mansona