Shoaib Ahmed

Results 29 comments of Shoaib Ahmed

> Maybe this check is redundant with the consensus state proof verification? i.e. if the host doesn't have the consensus state stored at that height, then the consensus state proof...

Related discussion on the hermes repo -> https://github.com/informalsystems/hermes/discussions/1508

> 3. (Preferable) it should be easy to release a fix to multiple versions; not just the latest (e.g. release it to 1.1.x and 1.2.x). Is it also a requirement...

> Is the ibc-rs ICS20 API readily usable? I think the `DummyTransferModule` implementation in the ibc-rs ICS20 PR gives us some confidence on the usability of the API as that...

## A comprehensive list of all that was required to implement Phase-3 ### High-level Components * MT-safe KV store as described in [ICS-024: Kev/Value Store](https://github.com/cosmos/ibc/blob/master/spec/core/ics-024-host-requirements/README.md#keyvalue-store) * IBC module with implementation...

Requirements for phase 4 are tracked via a branch -> https://github.com/informalsystems/ibc-rs/tree/basecoin/phase-4 See the diff here -> https://github.com/informalsystems/ibc-rs/compare/basecoin/phase-4

Thanks for sharing the issue @hxrts! 🙏 I wasn't aware of it. Just started looking at it, will make sure to keep this in mind before I start implementing gas...

We need this for https://github.com/informalsystems/ibc-rs/pull/1917 (so v0.23.x), but I think it will be nice to have this feature in newer versions as well.

Another potential solution using nested results (popularized by [sled-rs](https://github.com/spacejam/sled/blob/69294e59c718289ab3cb6bd03ac3b9e1e072a1e7/src/tree.rs#L2509-L2510)) -> ```rust type Verdict = Result; ```