swifter icon indicating copy to clipboard operation
swifter copied to clipboard

Published 20 hours ago • verified publisher icon httpswift

Fixed async array mutation on stop

Open cynicer opened this issue 2 years ago • 2 comments

The sockets array looped through in the stop method can be modified asynchronously by the start method. This leads to a very rare crash (I wasn't able to reproduce it in a test case consistently, but it happened from time to time). It's most likely even recorded by Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1608793

cynicer avatar Jul 15 '22 10:07 cynicer

Didn't experience this crash ever since applying this patch locally, would appreciate a review/merge.

cynicer avatar Aug 18 '22 06:08 cynicer

@Vkt0r could you review this PR maybe?

cynicer avatar Nov 29 '22 10:11 cynicer