swifter icon indicating copy to clipboard operation
swifter copied to clipboard

ambiguous use of `sha1`

Open SolaWing opened this issue 6 years ago • 1 comments

the String extension sha1 is conflict with CryptoSwift.

there are also many other names in extension may have a potencial collide with other's extension, like toBase64. so if these extensions only use internally, it can be marked as internal. or if need to use publicly, it should be added with prefix or namespace to avoid ambiguous

SolaWing avatar Dec 23 '18 09:12 SolaWing

Agreed, extensions should be marked internal unless they are needed for clients to use Swifter, and prefix makes sense for the properties and functions.

Though, the lack of prefix is as much a bug with CryptoSwift as it is with Swifter

adamkaplan avatar Dec 23 '18 21:12 adamkaplan