httplib2 icon indicating copy to clipboard operation
httplib2 copied to clipboard

http.client deprecated key_file, cert_file and check_hostname

Open Darkade opened this issue 8 years ago • 2 comments

Hello! As of python 3.6 the way HTTPSConnectionWithTimeout access the http.client library is using a deprecated call method.

Deprecated since version 3.6: key_file and cert_file are deprecated in favor of context. Please use ssl.SSLContext.load_cert_chain() instead, or let ssl.create_default_context() select the system’s trusted CA certificates for you.

The check_hostname parameter is also deprecated; the ssl.SSLContext.check_hostname attribute of context should be used instead.

https://docs.python.org/3/library/http.client.html

What can we do to begin using ssl.SSLContext?

Thanks!

Darkade avatar Aug 09 '17 19:08 Darkade

That would be a simple fix in http.client.HTTPSConnection() call, we already create a context, just didn't pass it.

temoto avatar Aug 16 '17 05:08 temoto

@Darkade please try again with 0.11.3 release or latest master commit. Should be fixed.

temoto avatar Apr 18 '18 19:04 temoto