Suggested fixes by iCR, OpenRefactory, Inc.

[openrefactory]

This issue was detected in branch master of httpie project on the version with commit hash 810bb1. This is an instance of a weak cryptography issue.

Fixes for weak cryptography issues: In file: update_warnings.py, method: _fetch_updates, there is code that turns off certificate validation while establishing an SSL/TLS connection. According to CWE 295, if a certificate is invalid or malicious, it might allow an attacker to spoof a trusted entity by interfering in the communication path between the host and client. iCR suggested that the certificate validation option should not be turned off.

This issue was detected by OpenRefactory's Intelligent Code Repair (iCR). We are running iCR on libraries in the PyPI repository to identify issues and fix them. More info at: pypi.openrefactory.com

[codecov-commenter]

Codecov Report

Base: 97.28% // Head: 94.59% // Decreases project coverage by -2.69% :warning:

Coverage data is based on head (a7d8c14) compared to base (4d7d6b6). Patch coverage: 90.94% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   97.28%   94.59%   -2.70%     
==========================================
  Files          67      109      +42     
  Lines        4235     7656    +3421     
==========================================
+ Hits         4120     7242    +3122     
- Misses        115      414     +299     

Impacted Files	Coverage Δ
httpie/output/ui/man_pages.py	0.00% <0.00%> (ø)
httpie/output/ui/rich_utils.py	0.00% <0.00%> (ø)
tests/test_binary.py	100.00% <ø> (ø)
tests/test_sessions.py	99.70% <ø> (-0.30%)	:arrow_down:
tests/test_ssl.py	92.59% <ø> (-2.35%)	:arrow_down:
tests/test_stream.py	100.00% <ø> (ø)
tests/test_tokens.py	100.00% <ø> (ø)
tests/test_update_warnings.py	99.14% <ø> (ø)
tests/test_uploads.py	96.70% <ø> (-3.30%)	:arrow_down:
tests/test_xml.py	97.56% <ø> (-0.06%)	:arrow_down:
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.