rho icon indicating copy to clipboard operation
rho copied to clipboard

Published 20 hours ago • verified publisher icon http4s

Swagger is generating invalid docs

Open bryce-anderson opened this issue 10 years ago • 3 comments

As noted in #46, the swagger validator has alerted us that the docs generated by the http4s demo are invalid.

bryce-anderson avatar Dec 09 '14 02:12 bryce-anderson

Is this still a thing?

jcranky avatar Dec 22 '16 12:12 jcranky

Yes, it's still not perfect.

bryce-anderson avatar Dec 24 '16 17:12 bryce-anderson

I looked into this a bit, and the example with bad docs is not entirely rho's fault: the return type of a route is a JValue, which has no special meaning to rho so it fails to build a proper model for it. The other example is twirl Html, which is the same issue.

I still think rho could be smarter about what it's adding as a ref etc to avoid situations like this.

bryce-anderson avatar Dec 27 '16 16:12 bryce-anderson