cache-tests icon indicating copy to clipboard operation
cache-tests copied to clipboard

Node `fetch` ignore HTTP_PROXY settings.

Open runningrunning opened this issue 1 year ago • 4 comments

The commit is https://github.com/http-tests/cache-tests/commit/dda5ccd194a5d768163a82ad62bd978be691bf58 It's mentioned in https://github.com/nodejs/node/issues/42814 and https://github.com/nodejs/node/issues/43187.

runningrunning avatar Feb 03 '25 09:02 runningrunning

Do you need to test a forward proxy? If not I'm inclined to just remove it from the docs for now.

mnot avatar Feb 03 '25 09:02 mnot

Well, I can workaround by manually revert this commit.

TBH, this repo help me a lot while developping the forward proxy, even from complementary purpose, I would suggest to at least mentioned it can be fixed or hotpatched through these two links in nodejs repo.

And I don't think it's only useful for forward proxy, it maybe needed to bypass network limitation. Or how does the nginx been tested in the benchmark?

runningrunning avatar Feb 03 '25 10:02 runningrunning

Since it's an issue in node already, maybe the doc can be just marked as a dependency. Or mentioned if it's needed, just manually revert this commit and wait until it's fixed on upstream.

runningrunning avatar Feb 03 '25 10:02 runningrunning

Node.js HTTP_PROXY support is coming, see https://github.com/nodejs/node/pull/57165

lifeisfoo avatar Mar 08 '25 14:03 lifeisfoo