http-client icon indicating copy to clipboard operation
http-client copied to clipboard

The IsahcClient timeout setting is not a connection timeout

Open trrk opened this issue 2 years ago • 1 comments

I believe the timeout that can be set through http_client refers to the connection timeout. And I think the process shown below sets a timeout on isahc. According to the isahc documentation, it is not the connection timeout that can be set with timeout(). The connection timeout can be set with connect_timeout(). https://github.com/http-rs/http-client/blob/3c0ed9a2f350749f48f579867139dd9e3afdf182/src/isahc.rs#L90 https://github.com/http-rs/http-client/blob/3c0ed9a2f350749f48f579867139dd9e3afdf182/src/isahc.rs#L118

trrk avatar Apr 10 '22 15:04 trrk

@trrk will accept a PR if you make one. :)

Fishrock123 avatar May 10 '22 01:05 Fishrock123