node-http-proxy icon indicating copy to clipboard operation
node-http-proxy copied to clipboard

Add follow-redirects options support

Open pachirel opened this issue 4 years ago • 1 comments
trafficstars

I saw issue #1412 and PR #1441. I'd like to support all follow-redirects options, I created another PR to support it.

I respect the attribute format of #1441.

Notes:

  • I found it's required to update DefinitelyTyped. Because followRedirects option is declared as boolean.
  • I haven't checked which follow-redirects versions support these options. I tested 1.9.0 (defined in package-lock.json) and 1.14.1. Please check your follow-redirects version.

pachirel avatar May 26 '21 02:05 pachirel

Codecov Report

Merging #1533 (f7f3c6a) into master (9b96cd7) will increase coverage by 0.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
+ Coverage   92.38%   92.52%   +0.14%     
==========================================
  Files           6        6              
  Lines         315      321       +6     
==========================================
+ Hits          291      297       +6     
  Misses         24       24              
Impacted Files Coverage Δ
lib/http-proxy/common.js 97.29% <100.00%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b96cd7...f7f3c6a. Read the comment docs.

codecov-commenter avatar May 26 '21 02:05 codecov-commenter