http-server icon indicating copy to clipboard operation
http-server copied to clipboard

--cors usage is incorrect in the documentation

Open sandeep-vedam opened this issue 2 years ago • 1 comments

--cors | Enable CORS via the Access-Control-Allow-Origin header The above documentation seems to be incorrect and it is confusing. As we can see through the code, that --cors will enable the Access-Control-Allow-Origin header and also the value set is assigned to the Access-Control-Allow-Headers . Possible values: should be like here --cors='X-Custom-Header'

Here is the line that supports above: https://github.com/http-party/http-server/blob/master/lib/http-server.js#L101-L107

sandeep-vedam avatar Apr 17 '23 13:04 sandeep-vedam

This issue has been inactive for 180 days

github-actions[bot] avatar Oct 15 '23 12:10 github-actions[bot]