htop icon indicating copy to clipboard operation
htop copied to clipboard

Numeric option items should have increment & decrement controls

Open Explorer09 opened this issue 3 years ago • 2 comments

A usability problem I recently discovered.

htop-display-numeric-options

In "Setup"->"Display options", several items take numeric values instead of boolean/checkbox. However, there're no obvious hints on how to adjust the value. The users have to guess which keys would adjust the values.

Suggestion: The function bar should include at least "increment" and "decrement" buttons for the numeric option item. This (1) shows the user which keys to press in order to adjust the values, and (2) it allows mouse users to adjust the values too.

I might also suggest a "revert" button in the function bar, but that would be a separate discussion.

Explorer09 avatar Aug 13 '21 04:08 Explorer09

Hi @Explorer09 , @BenBE,

I'd like to work on this little task. It's the first time I'll be working with the htop source code. I think this is a good place for me to start.

As @Explorer09 suggested, we can add | + | Increment | - | Decrement | buttons added to the function bar that only show up when the user is on a numeric value in the display options.

I see that the keys +, - increment and decrement the numeric values. But the Enter key increments the values as well. I found that the Enter key increments the values confusing. Should we keep it that way?

ahmedaabouzied avatar Aug 15 '21 05:08 ahmedaabouzied

Hi @ahmedaabouzied,

that's correct: The + and - keys increment and decrement the value respectively. The Enter key is intentional, as setting all the other (non-numeric) options reacts to Enter just the same.

If you have any questions or need some help with the implementation feel free to ask.

BenBE avatar Aug 15 '21 07:08 BenBE