reported htop version for releases is incorrect

[hadfl]

This seems to be a fallout of https://github.com/htop-dev/htop/commit/2acd62d3af56cf00fae62a86dda8bbca0f0b1913

When building htop for the 3.4.0 tagged release's tar.gz the version ends up like this:

htop --version
htop 3.4.0-dev-3.4.0

[fasterit]

This is a known issue and will be fixed again with 3.4.1. It is because the release manager forgot to update the right file. Humans happen. Packagers are advised to patch the configure.ac if they want to package 3.4.0 for distros.

[fasterit]

https://sources.debian.org/src/htop/3.4.0-2/debian/patches/ for inspiration

[hadfl]

Packagers are advised to patch the configure.ac if they want to package 3.4.0 for distros.

That's what we did for OmniOS. I just wanted to open the issue so other people are aware.

[HenrikBengtsson]

I closed #1679 again and comment here instead. I just built htop 3.4.1 from source on Ubuntu 22.04 and got:

$ htop --version
htop 3.4.1-3.4.1

I then built it on Rocky 8 and there I got what I expected:

$ htop --version
htop 3.4.1

I then went back to the Ubuntu 22.04 host and rebuilt it again, and now I got:

$ htop --version
htop 3.4.1

Hmm ... Despite using a build script that I have not modified, and wiping any file caches or previously built components, I can no longer reproduce this problem. This one is odd, and I have indeed had enough ☕ , so cannot blame that one. But hopefully my observations here add some clues.

UPDATE: I'm building from https://github.com/htop-dev/htop/archive/refs/tags/3.4.1.tar.gz, which I realized might not be the same as what's under https://github.com/htop-dev/htop/releases/tag/3.4.1.

[fasterit]

If you build from git, you get a git tag (and some changes info, in case you have some) after the dash. Build outside of git trees if you want release versions.