htop icon indicating copy to clipboard operation
htop copied to clipboard

default color preset: use bold blue for better visibility

Open eworm-de opened this issue 3 years ago • 2 comments

The default color preset works fine on dark background, with one exception: blue characters are hardly readable. So let's make (most of) these bold. Even bold blue is fine on light background, so this sould not make anything worse.

Addresses #1013

eworm-de avatar May 20 '22 21:05 eworm-de

Taking @BenBE 's feedback from #1013 here...

  • The [] brackets around inactive tabs look strange. Also the dark-grey on blue is kinda hard to read. Would be better to have black there for the tab text).

Yes, that was ugly... I misread the settings.

However dark font (dark-grey or black) on (dark) blue is hardly readable. The current commit changes this to white (non-bold, so light grey) on dark blue. Can we agree on this?

  • The digits overlapping the text at the right of meters are still dark blue, making that area hard to read (could be updated when touching this anyway)

Not sure what you are referencing here... Is this fixed in current commit already?

  • Can't check the ZRAM changes due to lack of having ZRAM configured.

Me neither. 😜 Well, could check in a VM...

eworm-de avatar May 23 '22 08:05 eworm-de

Taking @BenBE 's feedback from #1013 here...

  • The [] brackets around inactive tabs look strange. Also the dark-grey on blue is kinda hard to read. Would be better to have black there for the tab text).

Yes, that was ugly... I misread the settings.

However dark font (dark-grey or black) on (dark) blue is hardly readable. The current commit changes this to white (non-bold, so light grey) on dark blue. Can we agree on this?

Fine by me.

  • The digits overlapping the text at the right of meters are still dark blue, making that area hard to read (could be updated when touching this anyway)

Not sure what you are referencing here... Is this fixed in current commit already?

Reference to #930 …

BenBE avatar May 26 '22 13:05 BenBE

Merged the good commit, ignored the color-change-for-tabs one that was unrelated and making it harder to differentiate the active tab Thank you @eworm-de /DLange

fasterit avatar Dec 06 '22 17:12 fasterit

Did the unmerged commit cause any fallout I did not notice? Or should it go to a separate pull request?

After all I do not have a strong opinion on this as my tabs are hidden. Just wondering.

eworm-de avatar Dec 06 '22 17:12 eworm-de

No fallout, just more ugly than without your change :-)

fasterit avatar Dec 06 '22 17:12 fasterit