HTMLHint icon indicating copy to clipboard operation
HTMLHint copied to clipboard

feat: display warning log message when it can not parse config

Open is2ei opened this issue 3 years ago • 8 comments

fix #662

Short description of what this resolves: This PR changes it to display a warning log message when it can not parse config.

Proposed changes: Display warning log message

Screen Shot 2022-01-31 at 1 50 24

is2ei avatar Jan 30 '22 16:01 is2ei

Sorry but I would fix tests.

is2ei avatar Jan 30 '22 16:01 is2ei

Codecov Report

Merging #893 (f16d78c) into master (5a17fdd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #893   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files           2        2           
  Lines        1627     1627           
  Branches      291      291           
=======================================
  Hits         1573     1573           
  Misses         54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73bef2a...f16d78c. Read the comment docs.

codecov[bot] avatar Jan 30 '22 16:01 codecov[bot]

Tests are fixed. Could you review it?

is2ei avatar Jan 30 '22 16:01 is2ei

@thedaviddias Hi, would this change be acceptable? If not, I'll close this PR.

is2ei avatar Mar 22 '22 00:03 is2ei

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 25 '22 23:05 stale[bot]

@thedaviddias you approved this so can it be merged ?

coliff avatar Jun 11 '22 11:06 coliff

@thedaviddias you approved this so can it be merged ?

Yes, it can. @is2ei Can you just fix the conflict?

thedaviddias avatar Jul 22 '22 20:07 thedaviddias

@thedaviddias

I fixed the conflict. The test below fails, but I'm not sure it relates to this change. https://github.com/htmlhint/HTMLHint/runs/7480344654?check_suite_focus=true

is2ei avatar Jul 23 '22 10:07 is2ei