HTMLHint icon indicating copy to clipboard operation
HTMLHint copied to clipboard

feat: add config attribute extends

Open Shinigami92 opened this issue 4 years ago • 10 comments

Short description of what this resolves:

We want to support a extendable configuration file So we introduce a new configuration attribute extends that behave like eslint's extends

Proposed changes:

  • Add new attribute extends in configuration

Tasks:

  • [x] add extension ruleset map
  • [x] read new configuration structure
  • [x] pass config through to verify
  • [x] add tests
  • [x] define recommended ruleset

Shinigami92 avatar Jul 08 '20 18:07 Shinigami92

@thedaviddias Ready for review! 🎉

At first, you can only focus on changes to the source files Then, if you want, also look at the test files

We are getting closer to the release of version 1.0.0 😃

Shinigami92 avatar Jul 10 '20 17:07 Shinigami92

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 12 '20 10:09 stale[bot]

This was automatically closed without conclusion; extendable configuration is still desirable imho.

Schweinepriester avatar May 22 '21 01:05 Schweinepriester

Codecov Report

Merging #489 (59d55ca) into beta (e459672) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 59d55ca differs from pull request most recent head a763b2e. Consider uploading reports for the commit a763b2e to get more accurate results Impacted file tree graph

@@     Coverage Diff     @@
##   beta   #489   +/-   ##
===========================
===========================


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e459672...a763b2e. Read the comment docs.

codecov[bot] avatar Nov 24 '21 03:11 codecov[bot]

Configuration merge is still not available?

gitrequests avatar Jan 06 '22 11:01 gitrequests

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 10 '22 22:03 stale[bot]

Still think this is very desirable, shouldn't be closed and get keep-unstale.

Schweinepriester avatar Mar 13 '22 12:03 Schweinepriester

No news on this? This is a must-have feature in every linter imho.

ghaschel avatar Oct 06 '22 19:10 ghaschel

Any update on this PR? It would be really helpful when this functionality lands in HTMLHint.

donroyco avatar Feb 06 '23 07:02 donroyco

Are there any chances that this feature will be implemented to HTMLHint?

Thanks.

Kristinita avatar Feb 13 '24 14:02 Kristinita