carbon-fields icon indicating copy to clipboard operation
carbon-fields copied to clipboard

Compatibility issue with php 8.3.1

Open rstrah opened this issue 1 year ago • 2 comments

Version

3.6.3 - Carbon Fields: 6.4.3 - WordPress: 8.3.1 - PHP:

Expected Behavior

No errors like "Calling get_class() without arguments is deprecated"

Actual Behavior

https://prnt.sc/5qPRcRUFP_py

rstrah avatar Feb 15 '24 13:02 rstrah

Hello.

I have the same problem, I solved it by downgrading php to 8.1

alvarosego01 avatar May 07 '24 21:05 alvarosego01

Hello.

I have the same problem, I solved it by downgrading php to 8.1

carbon works with php 8.2, the get_class() needs to be replaced with static::class in 7 diff files. if you really want to use php 8.3

chrismccoy avatar Jun 08 '24 18:06 chrismccoy

Why would we not really want to use php8.3 ? ;)

Anyway, I saw there is a PR for this here, wondering if @htmlburger-git will consider that (or an improved version thereof?)

Update

Created #1239 without the flaws of #1223

kwisatz avatar Jul 15 '24 13:07 kwisatz

This was fixed in https://github.com/htmlburger/carbon-fields/pull/1239 and will be added to the next release.

atanas-vasilev-dev avatar Jul 23 '24 12:07 atanas-vasilev-dev

The fix for this issue is now released in https://github.com/htmlburger/carbon-fields/releases/tag/v3.6.5

atanas-vasilev-dev avatar Jul 31 '24 08:07 atanas-vasilev-dev