carbon-fields icon indicating copy to clipboard operation
carbon-fields copied to clipboard

Deprecated warnings using PHP 8+

Open sirjeff opened this issue 2 years ago • 4 comments

Version

  • Carbon Fields: 3.3.2
  • WordPress: 5.9.1
  • PHP: 8.1.2

Expected Behavior

No warnings

Actual Behavior

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetExists($id) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 128

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetGet($id) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 93

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetSet($id, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 74

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetUnset($id) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in \web\app\plugins\carbon-fields\core\Pimple\Container.php on line 138

Container definition

Steps to Reproduce the Problem

  1. Upgrade to PHP 8.1.2
  2. Warning appears at the top of every page

sirjeff avatar Mar 03 '22 03:03 sirjeff

Same issue here, with php 8.1

emanuellopes avatar Mar 28 '22 15:03 emanuellopes

Same here...

TCB13 avatar May 02 '22 17:05 TCB13

No movement on this since March. Who do I assign this problem to?

sirjeff avatar Jun 08 '22 02:06 sirjeff

@vvasilev- ??

sirjeff avatar Jun 08 '22 03:06 sirjeff

@tyxla or @jorostoyanov ?

sirjeff avatar Oct 16 '22 08:10 sirjeff

Hey folks, thanks for the ping, but I'm no longer working on this library.

tyxla avatar Oct 17 '22 08:10 tyxla

Same here

slaxxarn avatar Nov 11 '22 07:11 slaxxarn

Any update on this? 👀

aldveq avatar Dec 18 '22 00:12 aldveq

Same Deprecated warnings here for 8.1.

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetExists($id) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 128

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetGet($id) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 93

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetSet($id, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 74

Deprecated: Return type of Carbon_Fields\Pimple\Container::offsetUnset($id) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /sites/wpclothes2order.ajrsoftware.com/files/wp-content/plugins/wpclothes2order/vendor/htmlburger/carbon-fields/core/Pimple/Container.php on line 138

Is this lib still actively maintained?

AshleyRedman avatar Dec 20 '22 16:12 AshleyRedman

So is the end of the road for Carbon Fields then? Pity, because this library was/is awesome.

Is it still being maintained?

Ste-komodo avatar Jan 26 '23 13:01 Ste-komodo

Same issue with PHP 8.2.1

lautiamkok avatar Jan 30 '23 17:01 lautiamkok

Thanks for the notes. This has been fixed in the develop branch, we'll ship new version soon.

HTMLBurger-NG avatar Feb 08 '23 10:02 HTMLBurger-NG

Thank you.

TCB13 avatar Feb 08 '23 10:02 TCB13

Its May 28 2023, I'm running WP with PHP 8.1.3 - DId Carbon Fields get Updated so it doesn't crash? How do I get?

KennethErvinYoung avatar May 28 '23 19:05 KennethErvinYoung

Hi, You can solve this problem as below.

https://github.com/vlucas/phpdotenv/issues/504#issue-1073543626

rooteto avatar Jul 29 '23 08:07 rooteto

I've given up. We have paid ACF account anyway so I'll stick to the add-ons that are regularly updated. Nothing against the devs here, just I have to keep moving forward with projects :(

sirjeff avatar Oct 18 '23 03:10 sirjeff